Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more rules candidates #9

Open
4 tasks
aladdin-add opened this issue Feb 10, 2019 · 16 comments
Open
4 tasks

more rules candidates #9

aladdin-add opened this issue Feb 10, 2019 · 16 comments
Labels
help wanted Extra attention is needed

Comments

@aladdin-add
Copy link
Owner

aladdin-add commented Feb 10, 2019

@g-plane
Copy link
Collaborator

g-plane commented Feb 10, 2019

Also max-len, which will be hard.

@g-plane
Copy link
Collaborator

g-plane commented Feb 11, 2019

Do we need to consider indent if we implement "max-len"?

@aladdin-add
Copy link
Owner Author

every rule should be standalone. that's means it could not depend on rule indent.

related issue: eslint/eslint#11325

@g-plane
Copy link
Collaborator

g-plane commented Feb 11, 2019

If we implement "max-len", I think I don't need to use Prettier in other projects any more.

@g-plane
Copy link
Collaborator

g-plane commented Feb 12, 2019

Should we add autofix for "no-unreachable"?

@g-plane
Copy link
Collaborator

g-plane commented Feb 12, 2019

Does no-async-promise-executor need to be fixed?

@aladdin-add
Copy link
Owner Author

aladdin-add commented Feb 12, 2019

no-unreachabl sounds good to me!

not very sure about no-async-promise-executor. :(

@g-plane
Copy link
Collaborator

g-plane commented Feb 12, 2019

我们不妨去 ESLint 的列表找找哪些规则还没有 autofix 的,然后看看哪些值得去实现,接着在这个 repo 针对每个规则单独开 issue 进行讨论(实现思路),如果讨论没问题就打个 accepted 的 label,如果思路不可行就直接关闭掉 issue。你怎么看?

@aladdin-add
Copy link
Owner Author

可以,优先考虑在 eslint:recommended 中的规则

@g-plane
Copy link
Collaborator

g-plane commented Feb 24, 2019

我不确定还要不要实现 max-len 的 autofix,因为修复出来的结果往往是 opinionated 的,而我们也许不能保证这是不是用户想要的结果。

@aladdin-add
Copy link
Owner Author

aladdin-add commented Mar 25, 2019

  • sort-keys

refs: eslint/eslint#11542

@mekwall
Copy link

mekwall commented Feb 20, 2020

How about no-lone-blocks?`https://eslint.org/docs/rules/no-lone-blocks

@aladdin-add
Copy link
Owner Author

@mekwall sounds good to me!

@aladdin-add aladdin-add added the help wanted Extra attention is needed label Feb 20, 2020
@trajano
Copy link

trajano commented Apr 21, 2021

Someone implemented sort-keys but it was a year ago https://www.npmjs.com/package/eslint-plugin-sort-keys-fix

@danielanthonyl
Copy link

any updates on max-len?

@cseelus
Copy link

cseelus commented Feb 9, 2024

Please add max-len. Its the only thing holding me (and it seems others) back from throwing Prettier out …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

6 participants