Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete IPV6 support #588

Open
7 of 8 tasks
alanmcgovern opened this issue Dec 31, 2022 · 5 comments · Fixed by #590
Open
7 of 8 tasks

Complete IPV6 support #588

alanmcgovern opened this issue Dec 31, 2022 · 5 comments · Fixed by #590

Comments

@alanmcgovern
Copy link
Owner

alanmcgovern commented Dec 31, 2022

There are a few things I need to update to fully support ipv6. This includes:

@ycy1164656
Copy link

nice work,Im currently on vacation,but really looking forward to your accomplishment

@ycy1164656
Copy link

I added

AllowedEncryption = new[] { EncryptionType.PlainText },

in
image

in both monotorrent sampleclients on two computers,

one can connect to another, but the other one can not connect back

image

image

then ,nothing happened after this.

@alanmcgovern
Copy link
Owner Author

Interesting!

In my own testing I just checked that monotorrent can make an outgoing IPV6 connection to qbittorrent, and successfully transfer data. I didn't check if monotorrent handled incoming IPV6 connections from qbittorrent, or from another monotorrent client. I also didn't validate the behaviour of monotorrent being a seeder or leecher.

My strategy is to thread IPv6 support (as per various BEPs) through the engine, and then augment the integration tests contributed by @borigas to validate both ipv4 and ipv6 connections end-to-end.

Once the IPv6 variants of these tests are green, you should be good to go!

@ycy1164656
Copy link

Interesting!

In my own testing I just checked that monotorrent can make an outgoing IPV6 connection to qbittorrent, and successfully transfer data. I didn't check if monotorrent handled incoming IPV6 connections from qbittorrent, or from another monotorrent client. I also didn't validate the behaviour of monotorrent being a seeder or leecher.

My strategy is to thread IPv6 support (as per various BEPs) through the engine, and then augment the integration tests contributed by @borigas to validate both ipv4 and ipv6 connections end-to-end.

Once the IPv6 variants of these tests are green, you should be good to go!

brilliant ,really appreciate your work

@alanmcgovern
Copy link
Owner Author

@ycy1164656 I've just finalised this work (except for IPv6 DHT support).

#614

If you're comfortable testing code from git, could you check out that branch and see if everything works well for your case now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants