Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for files missing tests #77

Open
22 tasks
alarner opened this issue Aug 20, 2016 · 4 comments
Open
22 tasks

Add unit tests for files missing tests #77

alarner opened this issue Aug 20, 2016 · 4 comments

Comments

@alarner
Copy link
Owner

alarner commented Aug 20, 2016

  • config/browserify.js
  • config/config.js
  • config/server.js
  • config/test.js
  • config/utils.js
  • config/webpack.js
  • lib/config.js
  • lib/logger.js
  • lib/middleware/flash-messages.js
  • lib/middleware/local-user.js
  • lib/middleware/logged-in.js
  • lib/middleware/response-format.js
  • lib/middleware/validate-auth-profile.js
  • lib/middleware/validate-auth-type.js
  • lib/middleware/validate-local-credentials.js
  • lib/middleware/versions.js
  • lib/auth/authenticator.js
  • lib/auth/create-auth.js
  • lib/auth/create-user.js
  • lib/auth/login.js
  • lib/auth/no-dupe.js
  • lib/auth/passport-setup.js
@justinkong94
Copy link

Hi, I'd like to work on this. How do I get started?

@alarner
Copy link
Owner Author

alarner commented Aug 22, 2016

Hey @justinkong94 that's awesome! We'd love your help. The first step will be to fork and clone (the forked copy) of the perk repository. Perk uses mocha, chai and sinon for unit tests and all tests are in the test directory.

A good place to start would be modifying the test/lib/config.js file which is designed to test the lib/config.js file. Right now this test only checks to make sure that the perk configuration object has one specific property (root) on it after being built. You could modify that test to also check for errors and env properties that are dynamically added.

If you're looking to start with something more challenging, adding new files to test some of the middleware would also be super helpful.

After making your changes you can push them to your fork and then submit a Pull Request. If you have any questions along the way feel free to post them here or join our slack channel (which I can invite you to).

Thanks again for offering to help!

@justinkong94
Copy link

Ok I'll start with the config.js file first. Thanks for the help!

@RobAWilkinson
Copy link

Any progress on this @justinkong94 ? Id hate to duplicate your work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants