Fix extra semicolon in tabWidthStyle

Needed after changes in #636
alecthomas · Jun 13, 2022 · c78b8a6 · c78b8a6
1 parent 806ca29
commit c78b8a6
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/formatters/html/html.go b/formatters/html/html.go
@@ -381,7 +381,7 @@ func (f *Formatter) styleAttr(styles map[chroma.TokenType]string, tt chroma.Toke
 
 func (f *Formatter) tabWidthStyle() string {
 	if f.tabWidth != 0 && f.tabWidth != 8 {
-		return fmt.Sprintf("; -moz-tab-size: %[1]d; -o-tab-size: %[1]d; tab-size: %[1]d", f.tabWidth)
+		return fmt.Sprintf("-moz-tab-size: %[1]d; -o-tab-size: %[1]d; tab-size: %[1]d", f.tabWidth)
 	}
 	return ""
 }

diff --git a/formatters/html/html_test.go b/formatters/html/html_test.go
@@ -108,6 +108,18 @@ func TestTableLineNumberNewlines(t *testing.T) {
 </span>`)
 }
 
+func TestTabWidthStyle(t *testing.T) {
+	f := New(TabWidth(4), WithClasses(false))
+	it, err := lexers.Get("bash").Tokenise(nil, "echo FOO")
+	assert.NoError(t, err)
+
+	var buf bytes.Buffer
+	err = f.Format(&buf, styles.Fallback, it)
+	assert.NoError(t, err)
+
+	assert.Regexp(t, `<pre.*style=".*background-color:[^;]+;-moz-tab-size:4;-o-tab-size:4;tab-size:4[^"]*".+`, buf.String())
+}
+
 func TestWithCustomCSS(t *testing.T) {
 	f := New(WithClasses(false), WithCustomCSS(map[chroma.TokenType]string{chroma.Line: `display: inline;`}))
 	it, err := lexers.Get("bash").Tokenise(nil, "echo FOO")