Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lexer for properties files #670

Merged
merged 2 commits into from Sep 3, 2022
Merged

Add lexer for properties files #670

merged 2 commits into from Sep 3, 2022

Conversation

pmwmedia
Copy link
Contributor

@pmwmedia pmwmedia commented Sep 2, 2022

Properties files are very common in Java projects (see https://en.wikipedia.org/wiki/.properties)

Known limitations of my lexer:

  • Multi line entries with trailing backspaces won't be detected (I don't know your lexer syntax well enough to solve this)
  • key value entries without = and : won't be detected (I have never seen such entries in real life)

Fixes #615

alecthomas
alecthomas approved these changes Sep 3, 2022
View reviewed changes
Copy link
Owner

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this, mind adding a test? 🙇

@pmwmedia
Copy link
Contributor Author

pmwmedia commented Sep 3, 2022

Sure, I have just added tests

@alecthomas
Copy link
Owner

Legend, thanks!

@alecthomas alecthomas merged commit a531e40 into alecthomas:master Sep 3, 2022
@pmwmedia pmwmedia mentioned this pull request Sep 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a lexer for properties
2 participants
@pmwmedia @alecthomas