Lexer for VHS #690
Merged
Lexer for VHS #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caarlos0
approved these changes
Oct 28, 2022
|
I'm happy to accept any lexers, but would mind making it an XML lexer please? The conversion should be straightforward. |
|
VHS looks cool, I have some uses for that :) |
Hey, yes of course! I will do that today! |
|
@maaslalani Is this all of the keywords/names? Just wondering because I see a few more in |
|
Ah good catch @jolheiser I definitely missed a few, I will add them in the XML lexer! Thanks! |
|
@alecthomas Switched over to XML parsers, thanks for the great project! |
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! We recently (today) launched a new project called VHS which involves a custom scripting language / DSL for input: https://github.com/charmbracelet/vhs
There were some requests to add a
Chromalexer for it so that you could do syntax highlighting. So, I've made a PR for the (simple) grammar.We also have a tree-sitter grammar available here: https://github.com/charmbracelet/tree-sitter-vhs
Totally understand if you are not able to merge this lexer until the language becomes more widely used! Thank you for making
Chroma!