More improvements to PowerShell lexer #708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
reviewed
Nov 14, 2022
| {"type":"Name","value":"C:"}, | ||
| {"type":"Punctuation","value":"\\"}, | ||
| {"type":"Text","value":" "}, | ||
| {"type":"Punctuation","value":"*."}, | ||
| {"type":"Name","value":"txt"}, | ||
| {"type":"Text","value":"\n\n"}, |
There was a problem hiding this comment.
Should this be TextWhitespace?
There was a problem hiding this comment.
Very minor nit and won't make any difference, so I merged it.
There was a problem hiding this comment.
I might do more improvements a bit later, so I can look into this next time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my last PR I thought I would go ahead and fix the rest of the issues I have found with the PowerShell lexer.
This PR contains some pretty big improvements to the PowerShell lexer. I have tested it with a lot of the built in themes to make sure no strange behaviour occurs and it looks good.
Most themes don't have support for all the token types so they don't show the full potential. I am using Hugo with a theme I have created myself which basically looks like VSCode and it looks very good.
Please let me know if you would like me to add or change anything.