Rust: Attempt to lex constant idents #741
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Rust style guide:
https://doc.rust-lang.org/beta/style-guide/advice.html#names
While giving that casing to nothing else. This means that we can attempt to lex constant idents by detecting if they are
SCREAMING_SNAKE_CASE
. I opted for at least 2 uppercase letters since I have seen generics use names likeT0
andT1
(albeit rarely). The word boundaries (\b
) are used to avoid lexing parts of idents that just so happen to have at least two consecutive uppercase letters like BTreeSet