Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cfengine3 #766

Merged
merged 2 commits into from Mar 17, 2023
Merged

cfengine3 #766

merged 2 commits into from Mar 17, 2023

Conversation

miekg
Copy link
Contributor

@miekg miekg commented Mar 17, 2023

  • Fix CommentPreproc
  • Fix NameClass

@miekg
Fix CommentPreproc
3bc88af 
Macros (i.e.) CommentPreproc need to be anchored as they are only
allowed to be put on the start of the line. This also solved the
conflict with nakedvar @(....).

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg
Fix NameClass
0fd76e7 
NameClass (`xxx::`) can _also_ contain variables, so add " and $ to the
allowed list in the regexp. This now also needs to be put earlier to
match before any strings.

Signed-off-by: Miek Gieben <miek@miek.nl>
@miekg
Copy link
Contributor Author

miekg commented Mar 17, 2023

fixes: #763

@alecthomas alecthomas merged commit cc132ed into alecthomas:master Mar 17, 2023
2 checks passed
@alecthomas
Copy link
Owner

Thanks!

@miekg miekg deleted the cfengine3 branch March 17, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@miekg @alecthomas