Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI performance optimisation plan #549

Closed
dkhurshudian opened this issue Nov 5, 2018 · 4 comments
Closed

UI performance optimisation plan #549

dkhurshudian opened this issue Nov 5, 2018 · 4 comments
Assignees
Labels
ui Issues related to Aleph’s frontend

Comments

@dkhurshudian
Copy link
Contributor

dkhurshudian commented Nov 5, 2018

I've done some optimization in #544 but there is always something that could be done better. This issue will serve as a place for performance-related suggestions and discussions.

@dkhurshudian
Copy link
Contributor Author

dkhurshudian commented Nov 5, 2018

  • blueprint icons has font-based and svg-based implementation each is ~100kb gzipped, our project uses both, we need to get a rid of font-based one. Additional keep an eye to this issue A way to only bundle icons you actually use palantir/blueprint#2193 to load only required icons.
  • Implement dynamic import for translations
  • Embed metadata to html

@dkhurshudian dkhurshudian self-assigned this Nov 5, 2018
@dkhurshudian dkhurshudian added the ui Issues related to Aleph’s frontend label Nov 5, 2018
@pudo
Copy link
Contributor

pudo commented Nov 5, 2018

Good stuff. I've spent a little bit of time thinking about (3) and short of introducing a node server process I can't really think of a good way for doing it. It's also locale-dependent, so it would need to be able to either do content negotiation, or get much larger.

@dkhurshudian
Copy link
Contributor Author

Good stuff. I've spent a little bit of time thinking about (3) and short of introducing a node server process I can't really think of a good way for doing it. It's also locale-dependent, so it would need to be able to either do content negotiation, or get much larger.

Actually I don't think embedding is the best solution, this is kind of reminder for us to keep in mind that we have to do something with this request.

@pudo
Copy link
Contributor

pudo commented Nov 6, 2018

Aye. In general I feel like the bulk of our performance issues is now back-end related, so I'd propose we focus on doing speed-ups there (already started), and do other work on the front-end.

@pudo pudo closed this as completed Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Issues related to Aleph’s frontend
Projects
None yet
Development

No branches or pull requests

2 participants