You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If people are using the gettext translate filter then the one packed with this control clashes and only partially works. It would be better if gettext version is marked as dependency with the control (like lokijs) so that users of this control can use the full functionality of gettext whilst also using this control.
Also there is no need to write your own translate functionality when it already exists here:
[(https://github.com/rubenv/angular-gettext)]
Please consider removing this filter from future versions of this control. In the meantime we are having to remove it from this control's source code which isn't ideal.
Thank you.
The text was updated successfully, but these errors were encountered:
I'm not really sure how the i18n code in this library would clash with anything else. Could you give me some more details on this issue? Or maybe a demo on jsbin (or similar)?
You will see directives work just fine, however the filters do not as your filter comes across this one. Angular does not provide namspacing in 1.x
'Show' should be '[MISSING] Show'
This library is very popular with Angular uses and it will cause people problems if trying to use it with your control.
The easy solution is just to rename yours, the long term one would be to use a translator plugin and remove your own translate code. The reason that will be the best long term solution is that it will allow people to plugin in their own translator without having to worry about internals.
Please let me know what further info you need.
I see the effect isn't quite the same to our application, what I see is that the labels are attempted to be translated (on the select control), so as you'd expect the effect is random as probably a "random" filter is being picked up.
If people are using the gettext translate filter then the one packed with this control clashes and only partially works. It would be better if gettext version is marked as dependency with the control (like lokijs) so that users of this control can use the full functionality of gettext whilst also using this control.
Also there is no need to write your own translate functionality when it already exists here:
[(https://github.com/rubenv/angular-gettext)]
Please consider removing this filter from future versions of this control. In the meantime we are having to remove it from this control's source code which isn't ideal.
Thank you.
The text was updated successfully, but these errors were encountered: