{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":776488179,"defaultBranch":"main","name":"controller-runtime","ownerLogin":"alexandremahdhaoui","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2024-03-23T16:42:16.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/80970827?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1713085064.0","currentOid":""},"activityList":{"items":[{"before":"0ad4c4c2d07b3a75881ad032ba8fb7f0387afb9f","after":"105349a24db40d371d0b37ceab1a77ab3d7a3c2d","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-27T10:08:11.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 simplify syntax\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 simplify syntax"}},{"before":"4fe2109febcabe1da97a30a28d877b5b5f52bb65","after":"0ad4c4c2d07b3a75881ad032ba8fb7f0387afb9f","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-27T10:07:38.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 simplify syntax\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 simplify syntax"}},{"before":"6449beb31d2106892e213dfe211a9598bf1754f8","after":"4fe2109febcabe1da97a30a28d877b5b5f52bb65","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-27T10:06:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 simplify syntax\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 simplify syntax"}},{"before":"2c1c30310de65ca720330fe34a9415618c0847d6","after":"6449beb31d2106892e213dfe211a9598bf1754f8","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-27T09:59:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 parse go.mod with modfile.Parse\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 parse go.mod with modfile.Parse"}},{"before":"67b27f27e514bd9ac4cf9a2d84dec089ece95bf7","after":"77435913f5134b524dc0b83e8ed754a3f4174281","ref":"refs/heads/main","pushedAt":"2024-04-27T08:59:14.000Z","pushType":"push","commitsCount":22,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"Merge pull request #2798 from alvaroaleman/bp\n\n:running: Bump k8s.io/* deps to 20240424213639-6b47d7dcbef7","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2265422668\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kubernetes-sigs/controller-runtime/issues/2798\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kubernetes-sigs/controller-runtime/pull/2798/hovercard\" href=\"https://github.com/kubernetes-sigs/controller-runtime/pull/2798\">kubernetes-sigs#2798</a> from alvaroaleman/bp"}},{"before":"87a14b0df7e79574e5057473b7c23b03e2cd2a88","after":"2c1c30310de65ca720330fe34a9415618c0847d6","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-26T13:45:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"Update Makefile\n\nCo-authored-by: Stefan Büringer <4662360+sbueringer@users.noreply.github.com>","shortMessageHtmlLink":"Update Makefile"}},{"before":"846b2c12b09f7f1bb54a143fbfa06c25ffd2b7f2","after":"87a14b0df7e79574e5057473b7c23b03e2cd2a88","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-18T18:35:57.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 verify go modules are in sync with upstream k/k\n\nThis commit addresses issues were go modules aren't in sync with\nupstream k/k by adding these changes:\n- add `tools/cmd/gomodcheck/main.go` to:\n  - Parse and compares k/k dependencies to controller-runtime's ones.\n  - If any version diffs is found, returns a payload describing the diffs\n    and exit 1.\n  - The user may exclude packages by passing them as arguments.\n- extend the `verify-modules` make target with `gomodcheck`.","shortMessageHtmlLink":"🌱 verify go modules are in sync with upstream k/k"}},{"before":"816be5e570c0603366079627d23e8e655b459cbe","after":"846b2c12b09f7f1bb54a143fbfa06c25ffd2b7f2","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-17T18:58:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 verify go modules are in sync with upstream k/k\n\nThis commit addresses issues were go modules aren't in sync with\nupstream k/k by adding these changes:\n- add `tools/cmd/gomodcheck/main.go` to:\n  - Parse and compares k/k dependencies to controller-runtime's ones.\n  - If any version diffs is found, returns a payload describing the diffs\n    and exit 1.\n  - The user may exclude packages by passing them as arguments.\n- extend the `verify-modules` make target with `gomodcheck`.","shortMessageHtmlLink":"🌱 verify go modules are in sync with upstream k/k"}},{"before":"75371f34d8dfba56541dccdc9d4710bb4d556c95","after":"816be5e570c0603366079627d23e8e655b459cbe","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-17T18:56:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"remove k8s.io/utils from gomodcheck upstreamRefs\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"remove k8s.io/utils from gomodcheck upstreamRefs"}},{"before":"c2deb09a33d2fb6c316b7230353376cba2005130","after":"75371f34d8dfba56541dccdc9d4710bb4d556c95","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-16T21:01:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 improve gomodcheck\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 improve gomodcheck"}},{"before":"86ad2dc266add10bf0a898c3b712e4e971499a4d","after":"c2deb09a33d2fb6c316b7230353376cba2005130","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-16T20:59:41.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 improve gomodcheck\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 improve gomodcheck"}},{"before":"45e166d1fd01582c927a4edfb0501185413d6bae","after":"67b27f27e514bd9ac4cf9a2d84dec089ece95bf7","ref":"refs/heads/main","pushedAt":"2024-04-16T17:39:24.000Z","pushType":"push","commitsCount":6,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"Merge pull request #2725 from alexandremahdhaoui/fix_fakeclient-patch-with-no-rv-should-succeed\n\n🐛 allow fakeclient to patch CR with no RV","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2204370665\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kubernetes-sigs/controller-runtime/issues/2725\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kubernetes-sigs/controller-runtime/pull/2725/hovercard\" href=\"https://github.com/kubernetes-sigs/controller-runtime/pull/2725\">kubernetes-sigs#2725</a> from alexandremahdhaoui/fix_f…"}},{"before":"714596f6a21a8af37e379531ea362f13b6741534","after":"86ad2dc266add10bf0a898c3b712e4e971499a4d","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-14T09:47:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 verify go modules are in sync with upstream k/k\n\nThis commit addresses issues were go modules aren't in sync with\nupstream k/k by adding these changes:\n- add `tools/cmd/gomodcheck/main.go` to:\n  - Parse and compares k/k direct dependencies to controller-runtime's\n    direct deps.\n  - If any version diffs is found, returns a payload describing the diffs\n    and exit 1.\n  - The user may exclude packages by passing them as arguments.\n- extend the `verify-modules` make target with `gomodcheck`.\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 verify go modules are in sync with upstream k/k"}},{"before":"00374dce628f072bca60832c65296761e3e1397a","after":"714596f6a21a8af37e379531ea362f13b6741534","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-14T09:34:12.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 verify go modules are in sync with upstream k/k\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 verify go modules are in sync with upstream k/k"}},{"before":"a98e7150d857210aeaff19fc81388588f15c5a53","after":"00374dce628f072bca60832c65296761e3e1397a","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-14T09:01:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 verify go modules are in sync with upstream k/k\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 verify go modules are in sync with upstream k/k"}},{"before":null,"after":"a98e7150d857210aeaff19fc81388588f15c5a53","ref":"refs/heads/sync_go_mod_kubernetes_kubernetes","pushedAt":"2024-04-14T08:57:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🌱 verify go modules are in sync with upstream k/k\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🌱 verify go modules are in sync with upstream k/k"}},{"before":"76d3d0826fa9dca267c70c68c706f6de40084043","after":"45e166d1fd01582c927a4edfb0501185413d6bae","ref":"refs/heads/main","pushedAt":"2024-04-14T08:56:59.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"Merge pull request #2773 from yak2p/fix/typo\n\n🌱 fix: typo of CacheReader comment","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2239429389\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kubernetes-sigs/controller-runtime/issues/2773\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kubernetes-sigs/controller-runtime/pull/2773/hovercard\" href=\"https://github.com/kubernetes-sigs/controller-runtime/pull/2773\">kubernetes-sigs#2773</a> from yak2p/fix/typo"}},{"before":"e08b286e313e0642b739c7c9bc1d31d7bb333d2f","after":"76d3d0826fa9dca267c70c68c706f6de40084043","ref":"refs/heads/main","pushedAt":"2024-04-06T20:38:31.000Z","pushType":"push","commitsCount":27,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"Merge pull request #2757 from vincepri/fix-race-rg-ch\n\n:bug: Runnable group should check if stopped before enqueueing","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2225811530\" data-permission-text=\"Title is private\" data-url=\"https://github.com/kubernetes-sigs/controller-runtime/issues/2757\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/kubernetes-sigs/controller-runtime/pull/2757/hovercard\" href=\"https://github.com/kubernetes-sigs/controller-runtime/pull/2757\">kubernetes-sigs#2757</a> from vincepri/fix-race-rg-ch"}},{"before":"66e510a8ae2159f0abef37034781999ba8d789f3","after":"d0c20b4307e80e2767395dc317f7aa7ca29f83a4","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-26T19:28:13.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 prevent leader election when shutting down a non-elected manager\n\nWhen leader election is enabled, a non-leader manager would never start the LeaderElection runnable group.\nThus, as the shutdown process calls the sync.Once Start func of the runnableGroup; it will start a new election.\nThis change ensures `Start` is ineffective during shutdown.\n\nThe test ensures the LeaderElection runnableGroup is not started during shutdown.\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🐛 prevent leader election when shutting down a non-elected manager"}},{"before":"aa2bbaa0322626ba345fdfce632275208d5af8da","after":"66e510a8ae2159f0abef37034781999ba8d789f3","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-26T15:07:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 prevent leader election when shutting down a non-elected manager\n\nWhen leader election is enabled, a non-leader manager would never start the LeaderElection runnable group.\nThus, as the shutdown process calls the sync.Once Start func of the runnableGroup; it will start a new election.\nThis change ensures `Start` is ineffective during shutdown.\n\nThe test ensures the LeaderElection runnableGroup is not started during shutdown.\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🐛 prevent leader election when shutting down a non-elected manager"}},{"before":"6574e9daf478d0ff7d3c584b4a668a8f092ddaae","after":"3a19b110547155624ae27c44f07c3a547595a128","ref":"refs/heads/fix_fakeclient-patch-with-no-rv-should-succeed","pushedAt":"2024-03-26T14:14:36.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 allow fakeclient to patch CR with no RV\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🐛 allow fakeclient to patch CR with no RV"}},{"before":"d357c369443bff6db2458915ea23beeaee8c6246","after":"6574e9daf478d0ff7d3c584b4a668a8f092ddaae","ref":"refs/heads/fix_fakeclient-patch-with-no-rv-should-succeed","pushedAt":"2024-03-26T14:13:09.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 allow fakeclient to patch CR with no RV\n\nSigned-off-by: Alexandre Mahdhaoui <alexandre.mahdhaoui@gmail.com>","shortMessageHtmlLink":"🐛 allow fakeclient to patch CR with no RV"}},{"before":"06d575d6660414965c861063398b4019d7fd2659","after":"aa2bbaa0322626ba345fdfce632275208d5af8da","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-25T09:19:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"add blocking runnable to m1","shortMessageHtmlLink":"add blocking runnable to m1"}},{"before":"49681ff16a4d13be1787fa290d06e4691ebaa637","after":"06d575d6660414965c861063398b4019d7fd2659","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-24T17:13:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 prevent leader election when shutting down a non-elected manager\n\nWhen leader election is enabled, a non-leader manager would never start the LeaderElection runnable group.\nThus, as the shutdown process calls the sync.Once Start func of the runnableGroup; it will start a new election.\nThis change ensures `Start` is ineffective during shutdown.\n\nThe test ensures the LeaderElection runnableGroup is not started during shutdown.","shortMessageHtmlLink":"🐛 prevent leader election when shutting down a non-elected manager"}},{"before":"57c612afb451232348fc5097db4c4d60b8af3e81","after":"d357c369443bff6db2458915ea23beeaee8c6246","ref":"refs/heads/fix_fakeclient-patch-with-no-rv-should-succeed","pushedAt":"2024-03-24T14:10:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 allow fakeclient to patch CR with no RV\n\n\\# Context\n\nThis PR should fix a bug\nhttps://github.com/kubernetes-sigs/controller-runtime/issues/2678 where\npatching a resource would throw a conflict error when the new object\ndoesn't specify any RV.\n\n- Because the new RV is an empty string, an error is thrown here:\n  https://github.com/kubernetes-sigs/controller-runtime/blob/01de80b092778fd35abd9e2371d54ce0953d4613/pkg/client/fake/client.go#L429-L430\n- The RV is nil, because the computed patch between the old and new\n  accessor doesn't include resourceVersion:\n  -\nhttps://github.com/evanphx/json-patch/blob/v5.9.0/v5/merge.go#L253-L273\n  - Witch is used by `client.MergeFrom()`:\n    https://github.com/kubernetes-sigs/controller-runtime/blob/v0.17.2/pkg/client/patch.go#L150-L152\n\n\\# Changes\n\n- Fix patch by setting the new accessors' RV to the old accessors' RV.\n- Add test to ensure the correct behavior","shortMessageHtmlLink":"🐛 allow fakeclient to patch CR with no RV"}},{"before":"22813992b2dc552c83b54b3964d5bbca6424b972","after":"57c612afb451232348fc5097db4c4d60b8af3e81","ref":"refs/heads/fix_fakeclient-patch-with-no-rv-should-succeed","pushedAt":"2024-03-24T14:09:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 allow fakeclient to patch CR with no RV\n\n\\# Context\n\nThis PR should fix a bug\nhttps://github.com/kubernetes-sigs/controller-runtime/issues/2678 where\npatching a resource would throw a conflict error when the new object\ndoesn't specify any RV.\n\n- Because the new RV is an null, an error is thrown here:\n  https://github.com/kubernetes-sigs/controller-runtime/blob/01de80b092778fd35abd9e2371d54ce0953d4613/pkg/client/fake/client.go#L429-L430\n- The RV is nil, because the computed patch between the old and new\n  accessor doesn't include resourceVersion:\n  -\nhttps://github.com/evanphx/json-patch/blob/v5.9.0/v5/merge.go#L253-L273\n  - Witch is used by `client.MergeFrom()`:\n    https://github.com/kubernetes-sigs/controller-runtime/blob/v0.17.2/pkg/client/patch.go#L150-L152\n\n\\# Changes\n\n- Fix patch by setting the new accessors' RV to the old accessors' RV.\n- Add test to ensure the correct behavior","shortMessageHtmlLink":"🐛 allow fakeclient to patch CR with no RV"}},{"before":null,"after":"22813992b2dc552c83b54b3964d5bbca6424b972","ref":"refs/heads/fix_fakeclient-patch-with-no-rv-should-succeed","pushedAt":"2024-03-24T13:52:45.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 allow fakeclient to patch CR with no RV","shortMessageHtmlLink":"🐛 allow fakeclient to patch CR with no RV"}},{"before":"4ef9863a29f672f94b714d890d0c44edf6873022","after":"49681ff16a4d13be1787fa290d06e4691ebaa637","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-23T17:32:10.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 prevent leader election when shutting down a non-elected manager","shortMessageHtmlLink":"🐛 prevent leader election when shutting down a non-elected manager"}},{"before":"364cd942226914c0618e6e1b4ec83706dfb6983e","after":"4ef9863a29f672f94b714d890d0c44edf6873022","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-23T17:31:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 prevent leader election when shutting down a non-elected manager","shortMessageHtmlLink":"🐛 prevent leader election when shutting down a non-elected manager"}},{"before":null,"after":"364cd942226914c0618e6e1b4ec83706dfb6983e","ref":"refs/heads/fix-non-elected-shutdown","pushedAt":"2024-03-23T17:00:56.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"alexandremahdhaoui","name":"Alexandre Mahdhaoui","path":"/alexandremahdhaoui","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/80970827?s=80&v=4"},"commit":{"message":"🐛 prevent new leader election when a non-elected manager is shutting down","shortMessageHtmlLink":"🐛 prevent new leader election when a non-elected manager is shutting …"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEO8YwQgA","startCursor":null,"endCursor":null}},"title":"Activity · alexandremahdhaoui/controller-runtime"}