Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add system install powershell #1068

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add system install powershell #1068

wants to merge 1 commit into from

Conversation

nitishkumar71
Copy link
Contributor

Description

Add powershell as system install application

Motivation and Context

How Has This Been Tested?

Using command sudo ./arkade system install pwsh produced below output

Installing Powershell to /usr/local/bin
Installing version: v7.4.2 for: x64
Downloading from: https://github.com/PowerShell/PowerShell/releases/download/v7.4.2/powershell-7.4.2-linux-x64.tar.gz
67.69 MiB / 67.69 MiB [--------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
Downloaded to: /tmp/arkade-3499737583/powershell-7.4.2-linux-x64.tar.gz
Unpacking Powershell to: /usr/local/bin/powershell

If updating or adding a new CLI to arkade get, run:

go build && ./hack/test-tool.sh TOOL_NAME

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

alexellis
alexellis reviewed May 14, 2024
View reviewed changes
cmd/system/powershell.go Outdated
}

command.Flags().StringP("version", "v", "", "The version or leave blank to determine the latest available version")
command.Flags().String("path", "/usr/local/bin", "Installation path, where a powershell subfolder will be created")
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I know most of what we install goes here, but this isn't the recommended path for PowerShell

Could you consult the docs and update?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nitishkumar71
add system install powershell
c5da660 
Signed-off-by: Nitishkumar Singh <nitishkumarsingh71@gmail.com>
@nitishkumar71
Copy link
Contributor Author

Retested the command after changes and it produced below output

sudo ./arkade system install pwsh
Installing version: v7.4.2 for: x64
Installing Powershell to /opt/microsoft/powershell/7
Downloading from: https://github.com/PowerShell/PowerShell/releases/download/v7.4.2/powershell-7.4.2-linux-x64.tar.gz
67.69 MiB / 67.69 MiB [--------------------------------------------------------------------------------------------------------------------------------------------------------------] 100.00%
Downloaded to: /tmp/arkade-3612803353/powershell-7.4.2-linux-x64.tar.gz
Unpacking Powershell to: /opt/microsoft/powershell/7/powershell
Creating Symbolic link to: /usr/bin/pwsh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexellis alexellis Awaiting requested review from alexellis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Powershell as system install
2 participants
@nitishkumar71 @alexellis