Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e tests failing for atuin #962

Closed
mkimberley opened this issue Jul 31, 2023 · 3 comments · Fixed by #1065
Closed

e2e tests failing for atuin #962

mkimberley opened this issue Jul 31, 2023 · 3 comments · Fixed by #1065

Comments

@mkimberley
Copy link
Contributor

Expected Behaviour

  • make e2e should report all tests passed when building arkade

Current Behaviour

  • make e2e fails on "Test_CheckTools/Download_of_atuin"

Possible Solution

  • Correct the URL location for the atuin tool

Steps to Reproduce (for bugs)

  • clone arkade
  • make e2e

Context

  • This issue stops all PRs from pasisng, as global tests are failing

If requesting a CLI for "arkade get"

How many downloads does this tool have? Check at:

https://somsubhra.github.io/github-release-stats/

If approved, are you willing to submit a pull request for this?

Your Environment

  • What Kubernetes distribution are you using?
kubectl version
  • Operating System and version (e.g. Linux, Windows, MacOS):
uname -a

cat /etc/os-release
  • What arkade version is this?
arkade version

failing at git commit 6f5d90e

@alexellis
Copy link
Owner

Thanks for raising this. And by the way Atuin seems to have arm binaries now if you wanted to send a PR to add them?

@mkimberley
Copy link
Contributor Author

I'll get a PR submitted!

@alexellis
Copy link
Owner

Is this still something you're taking care of @mkimberley ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants