Remove pre-releases from release_notes #186
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initially the release notes were being generated from the current tagged release (n) and the n-1 release, irrespective of whether n-1 was a full release. This change causes `getWorkingReleases()` to ignore any previous releases where `PreRelease` is set to `true`. The processing beyond this determination will continue to consider all commits between the two identified points, resulting in a fuller set of changes for a full release where Pre-Releases have occured in between. Signed-off-by: Richard Gee <richard@technologee.co.uk>
rgee0
force-pushed
the
excludePreRelease
branch
from
e2d78f6
to
58ebcd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently in draft as need to consider the effect in generation of release notes for a pre-release. As proposed, this would be cumulative over a number of pre-releases as
prereleaseis only consider when finding the previous release, so each pre-release will be considered against the previous full release.Signed-off-by: Richard Gee richard@technologee.co.uk
Description
Initially the release notes were being generated from the current tagged
release (n) and the n-1 release, irrespective of whether n-1 was a full
release. This change causes
getWorkingReleases()to ignore any previousreleases where
PreReleaseis set totrue. The processing beyond thisdetermination will continue to consider all commits between the two identified
points, resulting in a fuller set of changes for a full release where
Pre-Releases have occurred in between.
Motivation and Context
Closes #184
How Has This Been Tested?
TBC
Types of changes
Checklist:
git commit -s