WIP: Move to golang-http-template #180
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes alexellis#96 Might also close alexellis#123 Signed-off-by: zoidbergwill <zoidbergwill@users.noreply.github.com>
|
Thank you for your contribution. It seems that one or more of your commits have an anonymous email address. Please consider signing your commits with a valid email address. Please see our contributing guide. |
|
@zoidbergwill this will need some end to end testing, please see the dev guide in the repository. faasd is probably the easiest to set up on a public cloud VM, or use inlets to connect your local OpenFaaS environment to GitHub for webhooks. https://inlets.dev/blog/2020/10/15/openfaas-public-endpoints.html |
|
@zoidbergwill if you have any questions please feel free to drop by on Slack https://slack.openfaas.io in the #contributors channel |
|
Closing as abandoned. |
|
Sorry, I'll try pick this up again in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've been trying to do some work on #96 and #123, but maybe I should break it up into multiple PRs.
I definitely need to test it more.
Maybe all the changes will make the most sense to do at once.
Motivation and Context
Closes #96
Might also close #123
How Has This Been Tested?
I've mainly tested this using
go testbut I should test it properly by actually deploying it with openfaas and things.I thought it'd be useful to make an MR sooner rather than later, to get as much feedback and direction as possible, since I'm an openfaas noob.
Types of changes
This change should not break backwards compatibility or the success cases, but might subtly affect some of the error cases, if we are giving more descriptive error messages and status codes.
Checklist:
git commit -s