Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing colors #47

Open
idleberg opened this issue Jun 21, 2022 · 3 comments
Open

Missing colors #47

idleberg opened this issue Jun 21, 2022 · 3 comments

Comments

@idleberg
Copy link

I'm not sure if the aim of this project is feature-parity with chalk, but since there's a migration guide and a benchmark comparison, this is probably the case. There are some colors missing in this project that are supported in chalk:

  1. bgGray
  2. all bright colors
    • blackBright / bgBlackBright
    • redBright / bgRedBright
    • greenBright / bgGreenBright
    • yellowBright / bgYellowBright
    • blueBright / bgBlueBright
    • magentaBright / bgMagentaBright
    • cyanBright / bgCyanBright
    • whiteBright / bgWhiteBright

The first looks like an oversight to me, since gray is available. I'm not sure about the bright colors though, otherwise I would have submitted a PR. Are you interested in supporting the full range of colors available in chalk?

@alexeyraspopov
Copy link
Owner

I think it's reasonable to support these. Let me see how we can do it without sacrificing package size

@robblovell
Copy link

It would be great if picocolors supported arbitrary colors with a .rgb([red], [blue], [green]) method. For instance pc.rgb(255,255,0) would produce yellow.

@MHase
Copy link

MHase commented Aug 15, 2023

is there any roadmap to introduce bright variants? 🤔
I think this is the only thing that is missing to allow picolors beat its competition, cause performance and size is already outstanding!

EDIT: just added a PR for this 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants