feat: ignore node_modules folder in projects option glob
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JounQin
reviewed
May 25, 2022
|
Is that possible to add a test case for it? |
JounQin
requested changes
May 25, 2022
|
do you have some guidance how a test for this should look like |
A new test folder with custom and nested |
JounQin
changed the title
node_modules folder in projects option globnode_modules folder in projects option glob
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ensures to not include the
node_modulesfolder when expanding theprojectsoption glob.(similar to what
@typescript-eslint/parserdoes, but withglobbynotglob, see https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/typescript-estree/src/parser.ts#L296-L306)