feature: allow passing through custom options to resolve #79
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @JounQin please let me know if you have any questions or concerns about these changes. For some more info on our use case, we are using this to pass in a custom |
|
Seems nice to have to me. But this should be a |
markjm
changed the title
fair, I have fixed up the commit and commit message |
|
@markjm |
JounQin
reviewed
Jul 30, 2021
|
Thank you! @markjm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
letting us pass our own options (via settings in .eslintrc.js allows us to override all of the settings specified in https://www.npmjs.com/package/resolve - not just the ones this project "knows" about. spreading these first will ensure that the settings this project knows about will still work/override as expected while letting others pass through.