Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode support cannot be overridden at runtime #174

Open
eliburke opened this issue Feb 12, 2020 · 0 comments
Open

Dark mode support cannot be overridden at runtime #174

eliburke opened this issue Feb 12, 2020 · 0 comments

Comments

@eliburke
Copy link
Contributor

Problem Description:
#170 added Dark Mode support in a simplistic manner: If running on iOS 13, use whatever color is provided by the operating system for the Dynamic Color systemBackground

If an App opts out of Dark Mode support by setting User Interface Style to .light in Info.plist, the dynamic colors match the old behavior. But it is also valid to honor Dark Mode and opt out for individual view controllers and their children.

Unfortunately, setting overrideUserInterfaceStyle = .light or passing a new UITraitCollection to new Window or ViewController does not change the definition of Dynamic Colors, when Dark Mode is enabled systemBackground is always black.

Suggestion:

  1. easy - update BltnItemManager to take a (default nil) UITraitCollection
  2. better - add backgroundColor and defaultActivityIndicatorColor to BLTNItemAppearance, update BltnItemManager to take an optional BltnInterfaceManager, and use the interfaceManager for both setting up the main card view, as well as passing it through to makeArrangedSubviews()

Thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant