Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass IPv6 addresses as host name in TLS connections #635

Merged
merged 1 commit into from
Jun 26, 2023
Merged

fix: pass IPv6 addresses as host name in TLS connections #635

merged 1 commit into from
Jun 26, 2023

Conversation

haraldh
Copy link
Contributor

@haraldh haraldh commented Jun 23, 2023

rustls does not like the brackets [] in rustls::ServerName::try_from().

algesten
algesten approved these changes Jun 25, 2023
View reviewed changes
Copy link
Owner

@algesten algesten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

I guess there are no cases where this is the incorrect thing to do?

@haraldh
fix: pass IPv6 addresses as host name in TLS connections
deae9cf 
rustls does not like the brackets `[]` in `rustls::ServerName::try_from()`.

Signed-off-by: Harald Hoyer <harald@matterlabs.dev>
@haraldh
Copy link
Contributor Author

haraldh commented Jun 26, 2023

Sorry, for the missing cargo fmt. I blame my IDE :)

@algesten algesten merged commit 4a2ecdf into algesten:main Jun 26, 2023
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algesten algesten algesten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@haraldh @algesten