fix(search): fix wait method for updateApiKey request (#1464)

algolia · Jun 7, 2023 · edc629d · edc629d
1 parent a4309c7
commit edc629d
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -98,7 +98,7 @@
   "bundlesize": [
     {
       "path": "packages/algoliasearch/dist/algoliasearch.umd.js",
-      "maxSize": "7.95KB"
+      "maxSize": "8KB"
     },
     {
       "path": "packages/algoliasearch/dist/algoliasearch-lite.umd.js",

diff --git a/packages/client-search/src/methods/client/updateApiKey.ts b/packages/client-search/src/methods/client/updateApiKey.ts
@@ -9,6 +9,7 @@ import { MethodEnum } from '@algolia/requester-common';
 import { RequestOptions } from '@algolia/transporter';
 
 import {
+  ApiKeyACLType,
   getApiKey,
   GetApiKeyResponse,
   SearchClient,
@@ -37,14 +38,32 @@ export const updateApiKey = (base: SearchClient) => {
       'maxHitsPerQuery',
     ] as const;
 
+    // Check that all the fields retrieved through getApiKey are the same as the ones we wanted to update
     const hasChanged = (getApiKeyResponse: GetApiKeyResponse): boolean => {
       return Object.keys(updatedFields)
         .filter(
           (updatedField: any): updatedField is typeof apiKeyFields[number] =>
             apiKeyFields.indexOf(updatedField) !== -1
         )
         .every(updatedField => {
-          return getApiKeyResponse[updatedField] === updatedFields[updatedField];
+          // If the field is an array, we need to check that they are the same length and that all the values are the same
+          if (
+            Array.isArray(getApiKeyResponse[updatedField]) &&
+            Array.isArray(updatedFields[updatedField])
+          ) {
+            const getApiKeyResponseArray = getApiKeyResponse[updatedField] as
+              | readonly ApiKeyACLType[]
+              | readonly string[];
+
+            return (
+              getApiKeyResponseArray.length === updatedFields[updatedField].length &&
+              getApiKeyResponseArray.every(
+                (value, index) => value === updatedFields[updatedField][index]
+              )
+            );
+          } else {
+            return getApiKeyResponse[updatedField] === updatedFields[updatedField];
+          }
         });
     };