fix(insideBoundingBox): allow type to be a string too #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility for the
insideBoundingBox
type to be a string as well. The reason behind this improvement comes from the usage ofinsideBoundingBox
in instantsearch.js where it is used as a string.More details in this issue in instantsearch.js.
I suppose this PR adds breaking changes as functions using
insideBoundingBox
with the sole expectation of it to beReadonlyArray<readonly number[]>
will have to be updated to check if it is one of both.Here is an example of how it would be breaking:
( I searched to point this PR to v5 since it introduces breaking changes but could not find the related branch 😕)