Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom request function APIC-126 #1312

Merged
merged 2 commits into from
Oct 19, 2021
Merged

Conversation

millotp
Copy link
Contributor

@millotp millotp commented Oct 15, 2021

Jira ticket: APIC-126

Adds the customRequest function to the search client for all environment, to allows clients to use features that are not yet implemented.

I didn't find a way to automatically generate the algoliasearch/src/builds/*.ts files, I'm not sure if there is one.

@millotp millotp self-assigned this Oct 15, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 15, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1fd062e:

Sandbox Source
javascript-client-app Configuration

Haroenv
Haroenv previously approved these changes Oct 18, 2021
@Haroenv
Copy link
Contributor

Haroenv commented Oct 18, 2021

There's no automatic way ,it was still on the todo to infer those types (there should be a way, by calling addMethods at the right moment) but I didn't yet get the time to look into it.

@Haroenv
Copy link
Contributor

Haroenv commented Oct 18, 2021

Are you sure the method should be called customRequest and not simply request? is this already shipped in other clients?

@millotp
Copy link
Contributor Author

millotp commented Oct 18, 2021

It's done in Python and for Android, and it's called custom_request. This is part of the DI sprint

@Haroenv
Copy link
Contributor

Haroenv commented Oct 18, 2021

Makes sense. In theory js could still be an outlier, as it usually favours shorter method names, but I'll leave it up to you

@Haroenv
Copy link
Contributor

Haroenv commented Oct 18, 2021

you'll need to update the bundlesize in package.json based on the response in ci still by the way

@bodinsamuel
Copy link
Contributor

Are you sure the method should be called customRequest and not simply request? is this already shipped in other clients?

I would also favor request as it more discoverable, but if it was already done let's stay consistant and it can conflict in some language as Request is a very basic keyword

@millotp millotp merged commit 3cea192 into master Oct 19, 2021
@millotp millotp deleted the feat/custom-request branch November 10, 2021 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants