Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for the redirect object in SearchResponse #1443

Merged
merged 1 commit into from Mar 21, 2023
Merged

Fix for the redirect object in SearchResponse #1443

merged 1 commit into from Mar 21, 2023

Conversation

sfaiqh
Copy link
Contributor

@sfaiqh sfaiqh commented Mar 7, 2023

No description provided.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 7, 2023 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9ca119a:

Sandbox Source
javascript-client-app Configuration

@sfaiqh sfaiqh requested a review from Haroenv March 9, 2023 17:37
Haroenv
Haroenv previously approved these changes Mar 13, 2023
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems correct, is it live?

@Haroenv Haroenv requested review from shortcuts and removed request for francoischalifour and drodriguln March 13, 2023 10:59
shortcuts
shortcuts reviewed Mar 13, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as @Haroenv!

packages/client-search/src/types/SearchResponse.ts Show resolved Hide resolved
@shortcuts shortcuts mentioned this pull request Mar 13, 2023
Closed
@sfaiqh
Copy link
Contributor Author

sfaiqh commented Mar 13, 2023

this seems correct, is it live?

Yes

@sfaiqh
Copy link
Contributor Author

sfaiqh commented Mar 15, 2023

@Haroenv anything else needed on this PR?

shortcuts
shortcuts approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! :)

@shortcuts shortcuts enabled auto-merge (squash) March 21, 2023 07:49
@shortcuts shortcuts merged commit 6b0685c into master Mar 21, 2023
8 checks passed
@shortcuts shortcuts deleted the EMERCH-617 branch March 21, 2023 08:27
@shortcuts shortcuts mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shortcuts shortcuts shortcuts approved these changes

@Haroenv Haroenv Haroenv left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfaiqh @Haroenv @shortcuts