Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(neuralsearch): adding the semanticSearch settings to client-search #1450

Merged
merged 2 commits into from Mar 22, 2023

Conversation

cdhawke
Copy link
Contributor

@cdhawke cdhawke commented Mar 22, 2023

What

Update the existing typing to include semanticSearch with eventSources for configuring NeuralSearch.

Why

RFC: https://algolia.atlassian.net/wiki/spaces/NEUR/pages/4507369495/Event+Sources+for+Neural+Search

@cdhawke cdhawke self-assigned this Mar 22, 2023
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d1d960a:

Sandbox Source
javascript-client-app Configuration

@Haroenv
Copy link
Contributor

Haroenv commented Mar 22, 2023

is it normal that the terms neural and semantic both are used?

@cdhawke
Copy link
Contributor Author

cdhawke commented Mar 22, 2023

is it normal that the terms neural and semantic both are used?

Yes they're separate concepts. 'neural' is the hybrid between 'keyword' and 'semantic'. semanticSearch here are the settings used by that specific search strategy / engine / whatever™

Copy link
Member

@Jerska Jerska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! :)

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@shortcuts shortcuts merged commit a478ffd into master Mar 22, 2023
8 checks passed
@shortcuts shortcuts deleted the feat/neuralsearch/settings branch March 22, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants