Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): fix wait method for updateApiKey request #1464

Merged
merged 1 commit into from Jun 7, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jun 6, 2023

Fix the wait method of the updateApiKey request so it really waits for an update on the key instead of directly resolving.

@Fluf22 Fluf22 requested review from millotp and shortcuts June 6, 2023 13:41
@Fluf22 Fluf22 self-assigned this Jun 6, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d14d739:

Sandbox Source
javascript-client-app Configuration

@Fluf22 Fluf22 force-pushed the fix/wait-key-update branch 14 times, most recently from 92c9e78 to 82339b9 Compare June 7, 2023 13:51
@Fluf22 Fluf22 marked this pull request as ready for review June 7, 2023 14:14
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks for tackling this :)

@Fluf22
Copy link
Contributor Author

Fluf22 commented Jun 7, 2023

@shortcuts thanks! I'll let you merge, I'm not authorized 😁

@shortcuts shortcuts merged commit edc629d into master Jun 7, 2023
8 checks passed
@shortcuts shortcuts deleted the fix/wait-key-update branch June 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants