Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(recommend): getTrendingFacets typing #1494

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

marialungu
Copy link

The hits returned by getTrendingFacets differ (they only have faceValue, facetName and _score) from the normal hits returned by the other recommendation methods.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@marialungu marialungu requested review from raed667 and jojva December 5, 2023 13:02
@marialungu marialungu changed the title Fix/recommend get trending facets typing fix(recommend): getTrendingFacets typing Dec 5, 2023
Copy link
Contributor

@raed667 raed667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM 🥇

Copy link

@jojva jojva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shortcuts
Copy link
Member

lmk if you need help for the release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants