fix(recommend): update TrendingFacetHit facetValue type to string #1498
+7
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The
trending-facets
API only returns typestring
forfacetValue
.A follow-up on #1494 as other models return items/hits which are of type
RecordWithObjectID
However,
trending-facets
model returns a list of TrendingFacetHit which (by definition) don't have anobjectID
property.How
To simplify the code, we can remove the type argument
TObject
fortrending-facets
Impact
If you're not using TypeScript or the
trending-facets
model, there is nothing to change. You can ignore the following.Otherwise, you will need to remove the type argument passed to
getTrendingFacets
and the code goes from this:To this: