From 5700dea65888dd71614566ac3219e9314eecd637 Mon Sep 17 00:00:00 2001 From: Ana Maria Gabriela Lungu Date: Thu, 15 Dec 2022 16:32:25 +0100 Subject: [PATCH 1/3] fix: remove unused props for trending facets --- .gitignore | 2 ++ packages/recommend/src/types/TrendingFacetsQuery.ts | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index d3371af10..6fe81554d 100644 --- a/.gitignore +++ b/.gitignore @@ -6,3 +6,5 @@ dist *.umd.js yarn-error.log .env + +.idea/ diff --git a/packages/recommend/src/types/TrendingFacetsQuery.ts b/packages/recommend/src/types/TrendingFacetsQuery.ts index 1c25ec4b8..7dc5380d3 100644 --- a/packages/recommend/src/types/TrendingFacetsQuery.ts +++ b/packages/recommend/src/types/TrendingFacetsQuery.ts @@ -1,3 +1,3 @@ import { TrendingQuery } from './TrendingQuery'; -export type TrendingFacetsQuery = Omit; +export type TrendingFacetsQuery = Omit; From 8ed81edeb03032cad85f0e7ef3fc5f9952904bdc Mon Sep 17 00:00:00 2001 From: Ana Maria Gabriela Lungu Date: Thu, 15 Dec 2022 17:26:00 +0100 Subject: [PATCH 2/3] fix lint --- packages/recommend/src/types/TrendingFacetsQuery.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/recommend/src/types/TrendingFacetsQuery.ts b/packages/recommend/src/types/TrendingFacetsQuery.ts index 7dc5380d3..6d58164dd 100644 --- a/packages/recommend/src/types/TrendingFacetsQuery.ts +++ b/packages/recommend/src/types/TrendingFacetsQuery.ts @@ -1,3 +1,6 @@ import { TrendingQuery } from './TrendingQuery'; -export type TrendingFacetsQuery = Omit; +export type TrendingFacetsQuery = Omit< + TrendingQuery, + 'model' | 'facetValue' | 'fallbackParameters' | 'queryParameters' +>; From e3e3692b91b7c66dc3bf8019cbed06d3c6cff6e0 Mon Sep 17 00:00:00 2001 From: Ana Maria Gabriela Lungu Date: Fri, 16 Dec 2022 11:28:16 +0100 Subject: [PATCH 3/3] revert changes to gitignore file --- .gitignore | 2 -- 1 file changed, 2 deletions(-) diff --git a/.gitignore b/.gitignore index 6fe81554d..d3371af10 100644 --- a/.gitignore +++ b/.gitignore @@ -6,5 +6,3 @@ dist *.umd.js yarn-error.log .env - -.idea/