Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for "unknown" parameters in DocSearch config #326

Open
JanPetr opened this issue Jan 18, 2017 · 1 comment
Open

Add check for "unknown" parameters in DocSearch config #326

JanPetr opened this issue Jan 18, 2017 · 1 comment

Comments

@JanPetr
Copy link

JanPetr commented Jan 18, 2017

I had a min_indexed_lvl parameter in a config, but the parameter is actually called min_indexed_level. But DocSearch scraper crawled the site as usual and I had no idea there is something wrong.

Is it possible to add a check which would raise a warning message when there are “unknown” parameters in the config?

@ElPicador
Copy link
Contributor

Yeah you are right, I had the same issue :/

We have some validations: https://github.com/algolia/docsearch-scraper/blob/master/scraper/src/config/config_validator.py

It should be pretty easy to had more validations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants