Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output CI-friendly progress messages #422

Open
mojavelinux opened this issue Dec 10, 2018 · 4 comments
Open

Output CI-friendly progress messages #422

mojavelinux opened this issue Dec 10, 2018 · 4 comments

Comments

@mojavelinux
Copy link
Contributor

Currently, the scraper assumes it's writing progress messages to an ANSI-compatible terminal. As a result, the progress messages look like this in a CI environment:

[94m> DocSearch: [0mhttps://docs.couchbase.com/server/6.0/introduction/intro.html ([93m51 records[0m)
[94m> DocSearch: [0mhttps://docs.couchbase.com/home/contribute/includes.html ([93m23 records[0m)
[94m> DocSearch: [0mhttps://docs.couchbase.com/server/6.0/n1ql/n1ql-language-reference/index.html ([93m28 records[0m)

Either add an option to output plain messages or automatically detect if ANSI color codes are not supported.

The easiest way to accomplish this might be to route the messages through a logger which can be configured separately. I'd also be interested in silencing the messages completely, which a logger would also help with.

@mojavelinux
Copy link
Contributor Author

I should note that not all CI environments have this problem. For instance, GitLab CI is capable of showing ANSI color codes. Jenkins, on the other hand, is not.

@s-pace
Copy link
Contributor

s-pace commented Dec 23, 2018

Having a proper logger is one of our objective at some point. No ETA so far, we will solve this while moving our codebase to a proper python v3/scrapy integration.

@mojavelinux
Copy link
Contributor Author

👍

If you need help, don't hesitate to ask. I'll be using docsearch for the foreseeable future, so I'll be around.

@s-pace
Copy link
Contributor

s-pace commented Dec 23, 2018

Thanks, send us an email docsearch@algolia.com, we have a small gift for you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants