Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with peer dependencies of @docsearch/react #1272

Open
brc-dd opened this issue Jan 16, 2022 · 2 comments
Open

Issue with peer dependencies of @docsearch/react #1272

brc-dd opened this issue Jan 16, 2022 · 2 comments
Labels
Needs investigation Investigation is planned but not started yet

Comments

@brc-dd
Copy link
Contributor

brc-dd commented Jan 16, 2022

Ref.: vuejs/vitepress#472 (comment)


@docsearch/js is using @docsearch/react with preact, but @docsearch/react wants react, react-dom, @types/react as its peer dependencies, which is throwing warnings. peerDependenciesMeta can be used to mark react (peer)dependencies in @docsearch/react as optional. (It is supported by latest versions of npm, yarn, pnpm.)

@brc-dd
Copy link
Contributor Author

brc-dd commented Jan 16, 2022

Also, I am not sure why @algolia/autocomplete-preset-algolia is listed as dependency of @docsearch/react.

@algolia/autocomplete-preset-algolia wants @algolia/client-search as a peer dependency, but @docsearch/react doesn't provide it, this is also giving a warning.

@shortcuts shortcuts added the Needs investigation Investigation is planned but not started yet label Feb 9, 2022
@sleeprite
Copy link

I also encountered this problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs investigation Investigation is planned but not started yet
Projects
None yet
Development

No branches or pull requests

3 participants