New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(styles): set medium breakpoint to standarized value #1446
Conversation
✅ Deploy Preview for docsearch canceled.
|
3fbd52d
to
9825604
Compare
768px has been much more common for many years (since 2010), and other major CSS frameworks have used 768px as the breakpoint for years. Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
9825604
to
b36b061
Compare
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9d2b83b:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It make sense indeed since it's standarized.
Could you group all of the changes in this PR please? It would make more sense in the changelog and if we need to point this change later.
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
@shortcuts Thank you. Both commits are now in this PR. Could you change the commit message with the below (or whatever you like) when you squash-merge?
|
768px has been much more common for many years (since 2010), and other major CSS frameworks have used 768px as the breakpoint for years.
Closes #1444
Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com