Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rules around disabling rules #112

Closed
Haroenv opened this issue Aug 12, 2019 · 2 comments · Fixed by #117
Closed

Add rules around disabling rules #112

Haroenv opened this issue Aug 12, 2019 · 2 comments · Fixed by #117

Comments

@Haroenv
Copy link
Contributor

Haroenv commented Aug 12, 2019

Some of our build scripts have errors in them that were suppressed by fully disabling the rules

In npm-search there were some unused disables that I didn't immediately find, having this will make our code simpler

Looking at that, I think we should enable all rules (except stylistic) for eslint-plugin-eslint-comments

@dispix
Copy link

dispix commented Aug 12, 2019

I think that makes a lot of sense!

@Haroenv
Copy link
Contributor Author

Haroenv commented Aug 12, 2019

Note there's also https://eslint.org/docs/user-guide/command-line-interface#--report-unused-disable-directives, but it doesn't go as far for restricting disables.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants