Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for rule "@typescript-eslint/array-type" is invalid #113

Closed
sarahdayan opened this issue Aug 17, 2019 · 3 comments · Fixed by #114
Closed

Configuration for rule "@typescript-eslint/array-type" is invalid #113

sarahdayan opened this issue Aug 17, 2019 · 3 comments · Fixed by #114
Labels

Comments

@sarahdayan
Copy link
Member

I got the following error when trying to lint my project with 'algolia/typescript':

Error: .eslintrc.js » eslint-config-algolia/typescript » ./rules/typescript.js:
        Configuration for rule "@typescript-eslint/array-type" is invalid:
        Value "array-simple" should be object.

Here's my config:

// .eslintrc.js

module.exports = {
  extends: 'algolia/typescript'
}

And relevant dependency versions:

  • babel-eslint: ^10.0.2
  • eslint: ^6.1.0
  • eslint-config-algolia: ^13.4.0
  • eslint-config-prettier: ^6.0.0
  • eslint-plugin-import: ^2.18.2
  • eslint-plugin-jest: ^22.15.1
  • eslint-plugin-prettier: ^3.1.0
  • prettier: ^1.18.2

I'll try to investigate later, but thought I'd file this in case someone wants to give it a spin.

@sarahdayan sarahdayan added the bug label Aug 17, 2019
@Haroenv
Copy link
Contributor

Haroenv commented Aug 19, 2019

I think it is because we didn't update the typescript plugin yet in InstantSearch, see typescript-eslint/typescript-eslint#654. In InstantSearch.js we are at v1.13.0 of the plugin. The PR there implies a breaking change in 2.0.0

@Haroenv
Copy link
Contributor

Haroenv commented Sep 10, 2019

temporary solution: use typescript-eslint@1.13.0 until this issue is closed

Haroenv added a commit that referenced this issue Sep 10, 2019
* feat(ts): compat for typescript-eslint 2

I based my changes on xojs/eslint-config-xo-typescript@1053f6b

and the changelog: https://github.com/typescript-eslint/typescript-eslint/blob/master/CHANGELOG.md#200-2019-08-13

fixes #113

This doesn't seem to be tested anywhere, so :fingers_crossed: haha

BREAKING CHANGE: /typescript requires typescript-eslint v2 now

* haha prettier you old chap
@Haroenv
Copy link
Contributor

Haroenv commented Sep 10, 2019

you can now use eslint-config-algolia@14 with typescript-eslint@2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants