Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add eslint-plugin-eslint-comments plugin #117

Merged
merged 1 commit into from Oct 9, 2019
Merged

feat: add eslint-plugin-eslint-comments plugin #117

merged 1 commit into from Oct 9, 2019

Conversation

yannickcr
Copy link
Contributor

@yannickcr yannickcr commented Oct 7, 2019 •
edited

Fixes #112

This change adds the eslint-plugin-eslint-comments plugin to the base configuration.

All rules from the Best Practices section are enabled.

This is a breaking change since the configuration requires a new peerDependency.

@yannickcr yannickcr requested a review from Haroenv October 7, 2019 14:36
Haroenv
Haroenv approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call on these !

@yannickcr yannickcr merged commit 47075c9 into master Oct 9, 2019
@yannickcr yannickcr deleted the feat/eslint-comments branch October 9, 2019 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rules around disabling rules
2 participants
@yannickcr @Haroenv