Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(react): add hooks rules #118

Merged
merged 2 commits into from Oct 9, 2019
Merged

feat(react): add hooks rules #118

merged 2 commits into from Oct 9, 2019

Conversation

francoischalifour
Copy link
Member

This adds the ESLint plugin for React hooks to enforce good hooks usage.

This is a breaking change because the peer dependency eslint-plugin-react-hooks is now required.

@francoischalifour francoischalifour mentioned this pull request Oct 7, 2019
Merged
yannickcr
yannickcr approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@yannickcr yannickcr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the Readme? (React and Flow with React sections)

LGTM otherwise 🙂

@francoischalifour francoischalifour merged commit 36492b3 into master Oct 9, 2019
@francoischalifour francoischalifour deleted the feat/react-hooks-plugin branch October 9, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannickcr yannickcr yannickcr approved these changes

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@francoischalifour @yannickcr @Haroenv