Skip to content

Commit

Permalink
fix(types): fix cssClasses of voiceSearch (#3783)
Browse files Browse the repository at this point in the history
* fix(types): fix cssClasses of voiceSearch

* fix(types): handle the situation where type of cssClasses of voiceSearch changes

* fix(types): change type of cssClasses of voiceSearch to fit in with the component
  • Loading branch information
Eunjae Lee committed May 20, 2019
1 parent 7fa2a1b commit f016326
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 10 deletions.
13 changes: 8 additions & 5 deletions src/components/VoiceSearch/VoiceSearch.tsx
@@ -1,18 +1,21 @@
import React from 'preact-compat';
import Template from '../Template/Template';

import {
VoiceSearchCSSClasses,
VoiceSearchTemplates,
} from '../../widgets/voice-search/voice-search';
import { VoiceSearchTemplates } from '../../widgets/voice-search/voice-search';

import {
VoiceListeningState,
ToggleListening,
} from '../../lib/voiceSearchHelper';

export type VoiceSearchComponentCSSClasses = {
root: string;
button: string;
status: string;
};

export type VoiceSearchProps = {
cssClasses: VoiceSearchCSSClasses;
cssClasses: VoiceSearchComponentCSSClasses;
isBrowserSupported: boolean;
isListening: boolean;
toggleListening: ToggleListening;
Expand Down
12 changes: 7 additions & 5 deletions src/widgets/voice-search/voice-search.tsx
Expand Up @@ -8,17 +8,19 @@ import { component } from '../../lib/suit';
import connectVoiceSearch, {
VoiceSearchRenderer,
} from '../../connectors/voice-search/connectVoiceSearch';
import VoiceSearch from '../../components/VoiceSearch/VoiceSearch';
import VoiceSearch, {
VoiceSearchComponentCSSClasses,
} from '../../components/VoiceSearch/VoiceSearch';
import defaultTemplates from './defaultTemplates';
import { WidgetFactory, Template } from '../../types';

const withUsage = createDocumentationMessageGenerator({ name: 'voice-search' });
const suit = component('VoiceSearch');

export type VoiceSearchCSSClasses = {
root: string;
button: string;
status: string;
root: string | string[];
button: string | string[];
status: string | string[];
};

type VoiceSearchTemplateProps = {
Expand All @@ -44,7 +46,7 @@ type VoiceSearchWidgetParams = {

interface VoiceSearchRendererWidgetParams extends VoiceSearchWidgetParams {
container: HTMLElement;
cssClasses: VoiceSearchCSSClasses;
cssClasses: VoiceSearchComponentCSSClasses;
templates: VoiceSearchTemplates;
}

Expand Down

0 comments on commit f016326

Please sign in to comment.