fix(getTag): use object version of toString #3820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE11: global `toString` can not be called as `Object.prototype.toString`, so we need to use the Object version, like done in lodash (not doing this initially was likely a simple omission)
ghost
requested review from
|
Deploy preview for instantsearchjs ready! Built with commit 3c6c3f0 |
samouss
reviewed
May 27, 2019
francoischalifour
approved these changes
May 27, 2019
|
other versions of |
Haroenv
added a commit
that referenced
this pull request
May 28, 2019
## [3.5.3](v3.5.2...v3.5.3) (2019-05-28) ### Bug Fixes * **voiceSearch:** let the connector handle the default value of searchAsYouSpeak when it's not given ([#3817](#3817)) ([9d3e91b](9d3e91b)) * **getTag:** use object version of toString ([#3820](#3820)) ([a7348ea](a7348ea)) * **types:** fix cssClasses of voiceSearch ([#3783](#3783)) ([f016326](f016326))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE11: global
toStringcan not be called asObject.prototype.toString, so we need to use the Object version, like done in lodash (not doing this initially was likely a simple omission)fixes #3814
references: