feat(current-refinements): provide indexId of refinements in transformItems #5546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
requested review from
a team,
FabienMotte and
aymeric-giraudet
and removed request for
a team
dhayab
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 820e263:
|
Haroenv
approved these changes
Mar 14, 2023
Haroenv
requested changes
Mar 14, 2023
Haroenv
approved these changes
Mar 15, 2023
pat-sullivan
pushed a commit
that referenced
this pull request
Mar 15, 2023
Haroenv
pushed a commit
that referenced
this pull request
Mar 16, 2023
* fix: add aria-hidden=true to all instances of ais-SearchBox-submitIcon * fix: add aria-hidden=true to all instances of ais-SearchBox-loadingIcon * fix: add aria-hidden=true to all instances of ais-SearchBox-resetIcon * fix: add remaining svg aria-hidden labels to components and IS search-box widget * chore: move aria-hidden attrs to top for a-z order * feat(current-refinements): provide indexId of refinements in transformItems (#5546) * chore: more aria-hidden attrs to top for a-z order --------- Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
currentRefinementswidget provides a way to transform/filter refined items to be returned, which is useful in multi-indices context, to potentially remove refinements from another index.This works well when indices are different, but in the context of multi-indices targeting the same index with different configuration, it is impossible to easily determine which refinements are from where.
This PR adds a
indexIdparameter to the items provided intransformItems, which solves this issue.