Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Missing pattern sentences in Pattern Matching in GOpt-based compilation #3774

Closed
BingqingLyu opened this issue May 8, 2024 · 0 comments · Fixed by #3805
Closed

[BUG] Missing pattern sentences in Pattern Matching in GOpt-based compilation #3774

BingqingLyu opened this issue May 8, 2024 · 0 comments · Fixed by #3805
Assignees

Comments

@BingqingLyu
Copy link
Collaborator

BingqingLyu commented May 8, 2024

Describe the bug

Based on the new GOpt-based compilation stack, the following pattern outputs unexpected plan:

g.V().match(__.as("a").out("2..3", "KNOWS").endV().as("c"), __.as("a").out("KNOWS").as("c")).count()

Currently, the optimized plan only preserves the PathExpand operator ( for out("2..3","KNOWS") ), while miss out the EdgeExpand ( for out("KNOWS") ) operator.

The plan looks like:

      PhysicalOpr {
            opr: Scan(...)
        PhysicalOpr {
            opr: Repartition(...),
        },
        PhysicalOpr {
            opr: Path(...),
        },
        PhysicalOpr {
            opr: Vertex(...),
        },
        PhysicalOpr {
            opr: GroupBy(...),
        },
        PhysicalOpr {
            opr: Sink(...),
        }
@BingqingLyu BingqingLyu changed the title [BUG] Unexpected results of pattern matching in GOpt-based compilation [BUG] Missing pattern sentences in Pattern Matching in GOpt-based compilation May 13, 2024
shirly121 pushed a commit that referenced this issue May 22, 2024
… in GOpt (#3805)

<!--
Thanks for your contribution! please review
https://github.com/alibaba/GraphScope/blob/main/CONTRIBUTING.md before
opening an issue.
-->

## What do these changes do?

<!-- Please give a short brief about these changes. -->

As titled. We throw out unsupported exception for multi-edge patterns in
GOpt (to avoid unexpected result for multi-edge pattern), and we will
support such patterns later.

## Related issue number

<!-- Are there any issues opened that will be resolved by merging this
change? -->

Fixes #3774

---------

Co-authored-by: Longbin Lai <longbin.lailb@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants