Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boa: support the esm for node.js >=14.5.0 #348

Closed
yorkie opened this issue Jul 15, 2020 · 2 comments
Closed

boa: support the esm for node.js >=14.5.0 #348

yorkie opened this issue Jul 15, 2020 · 2 comments
Labels
boa Python related issues community driven Community-driven issues

Comments

@yorkie
Copy link
Member

yorkie commented Jul 15, 2020

nodejs/node#33501 removed the ESM dynamic module format, and I skip the esm tests at #347, but we still need to add support for node(>=14.5.0), just ping to us if you are interested in this.
@yorkie yorkie added community driven Community-driven issues boa Python related issues labels Jul 15, 2020
@yorkie yorkie mentioned this issue Jul 15, 2020
Merged
@NHibiki
Copy link
Contributor

NHibiki commented Aug 7, 2020

@yorkie I am interested in this.

@NHibiki NHibiki mentioned this issue Aug 20, 2020
Merged
@yorkie
Copy link
Member Author

yorkie commented Aug 21, 2020

@NHibiki has fixed this issue at #348, thank you :p

@yorkie yorkie closed this as completed Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
boa Python related issues community driven Community-driven issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yorkie @NHibiki