Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: stream_read_notify may not be call #205

Open
Luffbee opened this issue Jul 8, 2022 · 0 comments
Open

[Bug]: stream_read_notify may not be call #205

Luffbee opened this issue Jul 8, 2022 · 0 comments
Assignees
@Kulsk
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🤩 someone working on it

Comments

@Luffbee
Copy link

Luffbee commented Jul 8, 2022

What happened?

xqc_stream_recv always calls xqc_stream_shutdown_read, so when a stream has received fin and then xqc_stream_recv does not consume all the data, the left data will never be notified to application.

Steps To Reproduce

Only call xqc_stream_recv once in stream_read_notify with a small buffer.

Relevant log output

No response
@ruiqizhou ruiqizhou added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Sep 2, 2022
@Kulsk Kulsk assigned Kulsk and unassigned lurker-Chen Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kulsk Kulsk

Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🤩 someone working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Luffbee @Kulsk @ruiqizhou @lurker-Chen