Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Unify the connection related interfaces. #234

Open
1 task done
Luffbee opened this issue Aug 29, 2022 · 0 comments
Open
1 task done

[Feature]: Unify the connection related interfaces. #234

Luffbee opened this issue Aug 29, 2022 · 0 comments

Comments

@Luffbee
Copy link

Luffbee commented Aug 29, 2022

Before request a new feature

  • I have searched the issues of this repository and believe that this is not a duplicate.

Describe the feature you'd like supported

The connection related interfaces are inconsistent: some use xqc_cid_t as user handler, some use xqc_connection_t*.
As xqc_cid_t is a complex type and must find the hash map to get the real connection context, using it as user handler is weird. Is there any reason to design like this?

IMO, using xqc_connection_t* as the user handler is the most convenient and most efficient way.

Describe alternatives you've considered

use xqc_connection_t* to replace all xqc_cid_t, and provide another interface const xqc_cid_t* xqc_conn_cid(xqc_connection_t*conn) to get the cid.

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant