New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to 5.1.0? Thank you #4
Comments
Hey Sebastian, It's good to hear from you again! 😊 I just wanted to let you know that I've finished updating the missing versions. Please take a look and let me know if you run into any issues. Thank you. |
Works great per usual, much appreciated |
Ugh, I'm very sorry, it's only after opening the Console that I realized there is a bug in the 5.1.0 release. This is unfortunate. If you don't mind I'll ping you when the 5.1.1 release is out with the fix. |
Don't sweat it, Sebastian! I'm on it 👨💻 The new version with the bug fix will be out as soon as it's ready (hopefully tomorrow!). I've got a notification set up, but feel free to reach out if I miss anything. |
5.2.0 is out :) https://github.com/react-icons/react-icons/releases/tag/v5.2.0 with the fix react-icons/react-icons#936 |
Hey Sebastien, pushing the new version live now! Thanks for the heads-up, feeling good about this one 😄 Let me know if anything comes up. |
Thanks. Alright, the sad news is that it's still broken, it seems React Icons is having some quality issues lately. Might be time for me to find a new avenue. |
hey Sebastien, I totally agree with you. We've been encountering challenges with React Icons for some time now due to the significant increase in bundle size and the sheer number of files included in the package. With over 145,000 files encompassing TypeScript type definitions and module files, it's become increasingly difficult to manage and maintain efficient deployment builds. Please let me know if you find a new solution. |
Consistency when it comes to icons is always a good thing within the same app. We started our app with Heroicons years ago since we were using Tailwind CSS already, then added missing icons from React Icons. Over time I noticed me picking our new icons from Tabler Icons almost exclusively, as it became clear that it was growing much faster than Heroicons itself. With 5,200+ icons, it is now almost 6 times larger than Heroicons, so I took a couple of hours to switch our old Heroicons icons to their equivalent in Tabler Icons, then removed our dependency to React Icons and Heroicons in favor of using Tabler Icons package directly. We only have about 190 icons, but it looks cleaner overall. Thanks for all the work! |
I really like the move to Tabler Icons! It creates a more consistent look for the app, and managing a single icon set is much easier. Great decision, Sebastien! I will consider this for our apps as well. Keep up the good work, Thank you. |
It's me again, and again :)
Thank for your work exposing all icons in one package. This is very helpful, as always.
Would you consider upgrading your package from 4.11.0 (Sep 6, 2023) to the recently released 5.1.0?
https://github.com/react-icons/react-icons/releases/tag/v5.1.0
Thank you very much
The text was updated successfully, but these errors were encountered: