From f516a0578c50cba12b4fee820781ad3d7441d9bc Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Tue, 8 Mar 2022 11:29:09 -0500 Subject: [PATCH 01/13] Update ami image and packages needed for compile Switch to Amazon Linux 2022: https://docs.aws.amazon.com/linux/al2022/ug/what-is-amazon-linux.html. Brotli is now a package that is installed. --- _/ansible/inventory.ini | 4 +-- _/ansible/plays/chromium.yml | 68 +++++++++++++++++++----------------- 2 files changed, 38 insertions(+), 34 deletions(-) diff --git a/_/ansible/inventory.ini b/_/ansible/inventory.ini index 2a91eb8..1f76bf7 100755 --- a/_/ansible/inventory.ini +++ b/_/ansible/inventory.ini @@ -3,8 +3,8 @@ [localhost:vars] ansible_connection=local -ansible_python_interpreter=python3 -image=ami-0de53d8956e8dcf80 +ansible_python_interpreter=python +image=ami-0fc0b1be4effdc8cc region=us-east-1 [aws] diff --git a/_/ansible/plays/chromium.yml b/_/ansible/plays/chromium.yml index 7c58da7..8b4ec94 100644 --- a/_/ansible/plays/chromium.yml +++ b/_/ansible/plays/chromium.yml @@ -86,26 +86,50 @@ - name: Installing Packages become: true become_user: root - yum: + dnf: name: - "@Development Tools" - - binutils - - bison - - bzip2 + - alsa-lib-devel + - atk-devel + - bc + - bluez-libs-devel + - brlapi-devel + - bzip2-devel + - cairo-devel - cmake - - curl + - cups-devel + - dbus-devel + - dbus-glib-devel - dbus-x11 - - flex - - git-core + - expat-devel + - glibc.i686 + - glibc-langpack-en - gperf - - patch + - gtk3-devel + - httpd + - java-11-openjdk-devel + - libatomic + - libcap-devel + - libjpeg-devel + - libstdc++.i686 + - libXScrnSaver-devel + - libxkbcommon-x11-devel + - mod_ssl + - ncurses-compat-libs + - nspr-devel + - nss-devel + - pam-devel + - pciutils-devel - perl + - php + - php-cli + - pulseaudio-libs-devel + - python + - python-psutil - python-setuptools - - python3 - - rpm - ruby - - subversion - - zip + - xorg-x11-server-Xvfb + - zlib.i686 state: latest update_cache: true @@ -158,26 +182,6 @@ path: /usr/local/bin/brotli register: brotli - - name: Cloning Brotli - git: - repo: https://github.com/google/brotli.git - dest: /srv/source/brotli - force: yes - update: yes - when: brotli.stat.exists != true - - - name: Compiling Brotli - become: true - become_user: root - shell: | - ./configure-cmake && \ - make && \ - make install - args: - chdir: /srv/source/brotli - creates: /usr/local/bin/brotli - when: brotli.stat.exists != true - - name: Cloning Depot Tools git: repo: https://chromium.googlesource.com/chromium/tools/depot_tools.git From fdf7b4d011653681983c6113119f7adfd16ef4ee Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Tue, 8 Mar 2022 11:30:25 -0500 Subject: [PATCH 02/13] Update compilation code --- _/ansible/plays/chromium.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/_/ansible/plays/chromium.yml b/_/ansible/plays/chromium.yml index 8b4ec94..625c4fb 100644 --- a/_/ansible/plays/chromium.yml +++ b/_/ansible/plays/chromium.yml @@ -196,14 +196,14 @@ - name: Fetching Chromium shell: | - fetch chromium + fetch --nohooks chromium args: chdir: /srv/source/chromium when: gclient.stat.exists != true - name: Resolving Puppeteer Version uri: - url: "https://raw.githubusercontent.com/GoogleChrome/puppeteer/{{ puppeteer_version | default('main') }}/src/revisions.ts" + url: "https://raw.githubusercontent.com/puppeteer/puppeteer/{{ puppeteer_version | default('main') }}/src/revisions.ts" return_content: yes register: puppeteer_revisions @@ -218,15 +218,15 @@ return_content: yes register: revision - - name: Checking Out Git Commit + - name: Checking Out Chromium revision shell: | - git checkout {{ revision.json.git_sha }} + gclient sync --delete_unversioned_trees --revision {{ revision.json.git_sha }} --with_branch_heads args: - chdir: /srv/source/chromium/src + chdir: /srv/source/chromium - - name: Synchronizing Chromium + - name: Run Chromium hooks shell: | - gclient sync --with_branch_heads + gclient runhooks args: chdir: /srv/source/chromium From c4c7a546871116fc6129530cf749d29b7ef2b291 Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Tue, 8 Mar 2022 11:30:52 -0500 Subject: [PATCH 03/13] Cleanup args.gn Some of the args are already in /build/args/headless.gn --- _/ansible/plays/chromium.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/_/ansible/plays/chromium.yml b/_/ansible/plays/chromium.yml index 625c4fb..5b1680e 100644 --- a/_/ansible/plays/chromium.yml +++ b/_/ansible/plays/chromium.yml @@ -278,28 +278,21 @@ content: | import("//build/args/headless.gn") blink_symbol_level = 0 - disable_ftp_support = true + dcheck_always_on = false disable_histogram_support = false enable_basic_print_dialog = false enable_basic_printing = true enable_keystone_registration_framework = false enable_linux_installer = false enable_media_remoting = false - enable_media_remoting_rpc = false - enable_nacl = false enable_one_click_signin = false ffmpeg_branding = "Chrome" - headless_use_embedded_resources = true - icu_use_data_file = false is_component_build = false is_debug = false proprietary_codecs = true symbol_level = 0 target_cpu = "x64" target_os = "linux" - use_bundled_fontconfig = true - use_cups = false - use_pulseaudio = false use_sysroot = true v8_target_cpu = "x64" dest: /srv/source/chromium/src/out/Headless/args.gn From db00197e88e986ce13ffe03aa1e2d126e156264f Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Wed, 9 Mar 2022 15:47:20 -0500 Subject: [PATCH 04/13] New OpenGL ES driver Also need to change a few flags --- _/ansible/plays/chromium.yml | 8 ++++---- source/index.ts | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/_/ansible/plays/chromium.yml b/_/ansible/plays/chromium.yml index 5b1680e..e239bc4 100644 --- a/_/ansible/plays/chromium.yml +++ b/_/ansible/plays/chromium.yml @@ -340,22 +340,22 @@ with_items: - "chromium-{{ version.stdout }}.br" - - name: Archiving SwiftShader + - name: Archiving OpenGL ES driver shell: | - tar --directory /srv/source/chromium/src/out/Headless/swiftshader --create --file swiftshader.tar libEGL.so libGLESv2.so + tar --directory /srv/source/chromium/src/out/Headless --create --file swiftshader.tar libEGL.so libGLESv2.so libvk_swiftshader.so libvulkan.so.1 vk_swiftshader_icd.json args: chdir: /srv/build/chromium creates: /srv/build/chromium/swiftshader.tar warn: false - - name: Compressing SwiftShader + - name: Compressing OpenGL ES driver shell: | brotli --best --force swiftshader.tar args: chdir: /srv/build/chromium creates: /srv/build/chromium/swiftshader.tar.br - - name: Downloading SwiftShader + - name: Downloading OpenGL ES driver fetch: src: /srv/build/chromium/swiftshader.tar.br dest: ../../../bin/ diff --git a/source/index.ts b/source/index.ts index cbfce35..cdf27ff 100644 --- a/source/index.ts +++ b/source/index.ts @@ -113,7 +113,8 @@ class Chromium { '--no-pings', // https://source.chromium.org/search?q=lang:cpp+symbol:kNoPings&ss=chromium '--no-sandbox', // https://source.chromium.org/search?q=lang:cpp+symbol:kNoSandbox&ss=chromium '--no-zygote', // https://source.chromium.org/search?q=lang:cpp+symbol:kNoZygote&ss=chromium - '--use-gl=swiftshader', // https://source.chromium.org/search?q=lang:cpp+symbol:kUseGl&ss=chromium + '--use-gl=angle', // https://chromium.googlesource.com/chromium/src/+/main/docs/gpu/swiftshader.md + '--use-angle=swiftshader', // https://chromium.googlesource.com/chromium/src/+/main/docs/gpu/swiftshader.md '--window-size=1920,1080', // https://source.chromium.org/search?q=lang:cpp+symbol:kWindowSize&ss=chromium ]; From 68a4616ac8c8fe2e6123d66a0693afe0cecae343 Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Thu, 10 Mar 2022 10:23:09 -0500 Subject: [PATCH 05/13] Update index.ts --- source/index.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source/index.ts b/source/index.ts index cdf27ff..994e8b7 100644 --- a/source/index.ts +++ b/source/index.ts @@ -202,7 +202,7 @@ class Chromium { try { return require('puppeteer'); - } catch (error) { + } catch (error: any) { if (error.code !== 'MODULE_NOT_FOUND') { throw error; } From f39bd42eee76038e012787054518f477564780cb Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Thu, 10 Mar 2022 10:25:22 -0500 Subject: [PATCH 06/13] Update puppeteer version to 13.5.0 Also drop node 10 --- Makefile | 2 +- _/amazon/template.yml | 11 ----------- _/ansible/inventory.ini | 2 +- package.json | 8 ++++---- 4 files changed, 6 insertions(+), 17 deletions(-) mode change 100755 => 100644 _/amazon/template.yml mode change 100755 => 100644 _/ansible/inventory.ini diff --git a/Makefile b/Makefile index b444917..76158f8 100644 --- a/Makefile +++ b/Makefile @@ -9,7 +9,7 @@ clean: %.zip: npm install --no-fund --no-package-lock --no-shrinkwrap mkdir -p nodejs/ - npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@~10.1.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap + npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@13.5.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap npm pack mkdir -p nodejs/node_modules/chrome-aws-lambda/ tar --directory nodejs/node_modules/chrome-aws-lambda/ --extract --file chrome-aws-lambda-*.tgz --strip-components=1 diff --git a/_/amazon/template.yml b/_/amazon/template.yml old mode 100755 new mode 100644 index 67f0741..6cae633 --- a/_/amazon/template.yml +++ b/_/amazon/template.yml @@ -12,20 +12,9 @@ Resources: LayerName: chrome-aws-lambda ContentUri: code/ CompatibleRuntimes: - - nodejs10.x - nodejs12.x - nodejs14.x - node10: - Type: AWS::Serverless::Function - Properties: - Layers: - - !Ref layer - Handler: handlers/index.handler - Runtime: nodejs10.x - Policies: - - AWSLambdaBasicExecutionRole - node12: Type: AWS::Serverless::Function Properties: diff --git a/_/ansible/inventory.ini b/_/ansible/inventory.ini old mode 100755 new mode 100644 index 1f76bf7..c2209eb --- a/_/ansible/inventory.ini +++ b/_/ansible/inventory.ini @@ -13,4 +13,4 @@ region=us-east-1 ansible_connection=ssh ansible_python_interpreter=auto_silent ansible_ssh_private_key_file=ansible.pem -puppeteer_version=v10.1.0 +puppeteer_version=v13.5.0 diff --git a/package.json b/package.json index d220714..4563424 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "chrome-aws-lambda", "private": false, - "version": "10.1.0", + "version": "13.5.0", "author": { "name": "Alix Axel" }, @@ -15,7 +15,7 @@ "typings" ], "engines": { - "node": ">= 10.16" + "node": ">= 12" }, "scripts": { "build": "rimraf build && tsc -p tsconfig.json", @@ -28,12 +28,12 @@ }, "devDependencies": { "@types/node": "^10.17.55", - "puppeteer-core": "^10.1.0", + "puppeteer-core": "13.5.0", "rimraf": "^3.0.2", "typescript": "4.3.2" }, "peerDependencies": { - "puppeteer-core": "^10.1.0" + "puppeteer-core": "13.5.0" }, "bugs": { "url": "https://github.com/alixaxel/chrome-aws-lambda/issues" From 2ca3619e3298a40a5ee46a9cd543932d0c8f7652 Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Wed, 20 Apr 2022 13:23:12 -0400 Subject: [PATCH 07/13] Update puppeteer version to 13.6.0 --- Makefile | 2 +- _/ansible/inventory.ini | 2 +- package.json | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index 76158f8..b0eff27 100644 --- a/Makefile +++ b/Makefile @@ -9,7 +9,7 @@ clean: %.zip: npm install --no-fund --no-package-lock --no-shrinkwrap mkdir -p nodejs/ - npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@13.5.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap + npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@13.6.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap npm pack mkdir -p nodejs/node_modules/chrome-aws-lambda/ tar --directory nodejs/node_modules/chrome-aws-lambda/ --extract --file chrome-aws-lambda-*.tgz --strip-components=1 diff --git a/_/ansible/inventory.ini b/_/ansible/inventory.ini index c2209eb..5c20512 100644 --- a/_/ansible/inventory.ini +++ b/_/ansible/inventory.ini @@ -13,4 +13,4 @@ region=us-east-1 ansible_connection=ssh ansible_python_interpreter=auto_silent ansible_ssh_private_key_file=ansible.pem -puppeteer_version=v13.5.0 +puppeteer_version=v13.6.0 diff --git a/package.json b/package.json index 4563424..e38e496 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "chrome-aws-lambda", "private": false, - "version": "13.5.0", + "version": "13.6.0", "author": { "name": "Alix Axel" }, @@ -28,12 +28,12 @@ }, "devDependencies": { "@types/node": "^10.17.55", - "puppeteer-core": "13.5.0", + "puppeteer-core": "13.6.0", "rimraf": "^3.0.2", "typescript": "4.3.2" }, "peerDependencies": { - "puppeteer-core": "13.5.0" + "puppeteer-core": "13.6.0" }, "bugs": { "url": "https://github.com/alixaxel/chrome-aws-lambda/issues" From 87d8d8f30dc8be20c948409c6ccff6414cf2df66 Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Tue, 3 May 2022 10:19:30 -0400 Subject: [PATCH 08/13] Update puppeteer version to 13.7.0 --- Makefile | 2 +- _/ansible/inventory.ini | 2 +- package.json | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index b0eff27..102bc08 100644 --- a/Makefile +++ b/Makefile @@ -9,7 +9,7 @@ clean: %.zip: npm install --no-fund --no-package-lock --no-shrinkwrap mkdir -p nodejs/ - npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@13.6.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap + npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@13.7.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap npm pack mkdir -p nodejs/node_modules/chrome-aws-lambda/ tar --directory nodejs/node_modules/chrome-aws-lambda/ --extract --file chrome-aws-lambda-*.tgz --strip-components=1 diff --git a/_/ansible/inventory.ini b/_/ansible/inventory.ini index 5c20512..99a05a5 100644 --- a/_/ansible/inventory.ini +++ b/_/ansible/inventory.ini @@ -13,4 +13,4 @@ region=us-east-1 ansible_connection=ssh ansible_python_interpreter=auto_silent ansible_ssh_private_key_file=ansible.pem -puppeteer_version=v13.6.0 +puppeteer_version=v13.7.0 diff --git a/package.json b/package.json index e38e496..194d7ee 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "chrome-aws-lambda", "private": false, - "version": "13.6.0", + "version": "13.7.0", "author": { "name": "Alix Axel" }, @@ -28,12 +28,12 @@ }, "devDependencies": { "@types/node": "^10.17.55", - "puppeteer-core": "13.6.0", + "puppeteer-core": "13.7.0", "rimraf": "^3.0.2", "typescript": "4.3.2" }, "peerDependencies": { - "puppeteer-core": "13.6.0" + "puppeteer-core": "13.7.0" }, "bugs": { "url": "https://github.com/alixaxel/chrome-aws-lambda/issues" From 082d3ae74df8b066b024fe57a9325725ef274b06 Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Mon, 9 May 2022 16:15:28 -0400 Subject: [PATCH 09/13] Upgrade puppeteer version to 14.0.0 node12 support removed per puppeteer v14.0.0 --- Makefile | 2 +- _/amazon/template.yml | 11 ----------- _/ansible/inventory.ini | 4 ++-- package.json | 8 ++++---- 4 files changed, 7 insertions(+), 18 deletions(-) diff --git a/Makefile b/Makefile index 102bc08..e7317dd 100644 --- a/Makefile +++ b/Makefile @@ -9,7 +9,7 @@ clean: %.zip: npm install --no-fund --no-package-lock --no-shrinkwrap mkdir -p nodejs/ - npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@13.7.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap + npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@14.0.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap npm pack mkdir -p nodejs/node_modules/chrome-aws-lambda/ tar --directory nodejs/node_modules/chrome-aws-lambda/ --extract --file chrome-aws-lambda-*.tgz --strip-components=1 diff --git a/_/amazon/template.yml b/_/amazon/template.yml index 6cae633..5f13f47 100644 --- a/_/amazon/template.yml +++ b/_/amazon/template.yml @@ -12,19 +12,8 @@ Resources: LayerName: chrome-aws-lambda ContentUri: code/ CompatibleRuntimes: - - nodejs12.x - nodejs14.x - node12: - Type: AWS::Serverless::Function - Properties: - Layers: - - !Ref layer - Handler: handlers/index.handler - Runtime: nodejs12.x - Policies: - - AWSLambdaBasicExecutionRole - node14: Type: AWS::Serverless::Function Properties: diff --git a/_/ansible/inventory.ini b/_/ansible/inventory.ini index 99a05a5..ccb7388 100644 --- a/_/ansible/inventory.ini +++ b/_/ansible/inventory.ini @@ -4,7 +4,7 @@ [localhost:vars] ansible_connection=local ansible_python_interpreter=python -image=ami-0fc0b1be4effdc8cc +image=ami-03425aeb2f345b9a9 region=us-east-1 [aws] @@ -13,4 +13,4 @@ region=us-east-1 ansible_connection=ssh ansible_python_interpreter=auto_silent ansible_ssh_private_key_file=ansible.pem -puppeteer_version=v13.7.0 +puppeteer_version=v14.0.0 diff --git a/package.json b/package.json index 194d7ee..d56c99a 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "chrome-aws-lambda", "private": false, - "version": "13.7.0", + "version": "14.0.0", "author": { "name": "Alix Axel" }, @@ -15,7 +15,7 @@ "typings" ], "engines": { - "node": ">= 12" + "node": ">= 14" }, "scripts": { "build": "rimraf build && tsc -p tsconfig.json", @@ -28,12 +28,12 @@ }, "devDependencies": { "@types/node": "^10.17.55", - "puppeteer-core": "13.7.0", + "puppeteer-core": "14.0.0", "rimraf": "^3.0.2", "typescript": "4.3.2" }, "peerDependencies": { - "puppeteer-core": "13.7.0" + "puppeteer-core": "14.0.0" }, "bugs": { "url": "https://github.com/alixaxel/chrome-aws-lambda/issues" From b420db12f353b00194dd5f1388f161cd6ba82c63 Mon Sep 17 00:00:00 2001 From: Steven Date: Fri, 13 May 2022 09:18:46 -0400 Subject: [PATCH 10/13] Add support for nodejs16.x --- source/index.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/source/index.ts b/source/index.ts index 994e8b7..0241d1b 100644 --- a/source/index.ts +++ b/source/index.ts @@ -7,7 +7,7 @@ import { join } from 'path'; import { PuppeteerNode, Viewport } from 'puppeteer-core'; import { URL } from 'url'; -if (/^AWS_Lambda_nodejs(?:10|12|14)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) { +if (/^AWS_Lambda_nodejs(?:10|12|14|16)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) { if (process.env.FONTCONFIG_PATH === undefined) { process.env.FONTCONFIG_PATH = '/tmp/aws'; } @@ -166,7 +166,7 @@ class Chromium { LambdaFS.inflate(`${input}/swiftshader.tar.br`), ]; - if (/^AWS_Lambda_nodejs(?:10|12|14)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) { + if (/^AWS_Lambda_nodejs(?:10|12|14|16)[.]x$/.test(process.env.AWS_EXECUTION_ENV) === true) { promises.push(LambdaFS.inflate(`${input}/aws.tar.br`)); } From bdf424fe255bc9094796a0fa31fb0097b69fc67f Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Mon, 16 May 2022 12:56:02 -0400 Subject: [PATCH 11/13] Puppeteer 14 updated esm support - @otaviosoares --- source/puppeteer/lib/Browser.ts | 4 ++-- source/puppeteer/lib/BrowserContext.ts | 4 ++-- source/puppeteer/lib/ElementHandle.ts | 4 ++-- source/puppeteer/lib/FrameManager.ts | 4 ++-- source/puppeteer/lib/Page.ts | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-) diff --git a/source/puppeteer/lib/Browser.ts b/source/puppeteer/lib/Browser.ts index cbcc1b8..6ed3eff 100644 --- a/source/puppeteer/lib/Browser.ts +++ b/source/puppeteer/lib/Browser.ts @@ -4,9 +4,9 @@ import { Hook, Prototype } from '../../../typings/chrome-aws-lambda'; let Super: Prototype = null; try { - Super = require('puppeteer/lib/cjs/puppeteer/common/Browser').Browser; + Super = require('puppeteer/lib/cjs/puppeteer/common/Browser.js').Browser; } catch (error) { - Super = require('puppeteer-core/lib/cjs/puppeteer/common/Browser').Browser; + Super = require('puppeteer-core/lib/cjs/puppeteer/common/Browser.js').Browser; } Super.prototype.defaultPage = async function (...hooks: Hook[]) { diff --git a/source/puppeteer/lib/BrowserContext.ts b/source/puppeteer/lib/BrowserContext.ts index f1ba941..774ae4a 100644 --- a/source/puppeteer/lib/BrowserContext.ts +++ b/source/puppeteer/lib/BrowserContext.ts @@ -4,9 +4,9 @@ import { Hook, Prototype } from '../../../typings/chrome-aws-lambda'; let Super: Prototype = null; try { - Super = require('puppeteer/lib/cjs/puppeteer/common/Browser').BrowserContext; + Super = require('puppeteer/lib/cjs/puppeteer/common/Browser.js').BrowserContext; } catch (error) { - Super = require('puppeteer-core/lib/cjs/puppeteer/common/Browser').BrowserContext; + Super = require('puppeteer-core/lib/cjs/puppeteer/common/Browser.js').BrowserContext; } Super.prototype.defaultPage = async function (...hooks: Hook[]) { diff --git a/source/puppeteer/lib/ElementHandle.ts b/source/puppeteer/lib/ElementHandle.ts index 0b1c457..071a0fb 100644 --- a/source/puppeteer/lib/ElementHandle.ts +++ b/source/puppeteer/lib/ElementHandle.ts @@ -4,9 +4,9 @@ import { KeysOfType, Prototype } from '../../../typings/chrome-aws-lambda'; let Super: Prototype = null; try { - Super = require('puppeteer/lib/cjs/puppeteer/common/JSHandle').ElementHandle; + Super = require('puppeteer/lib/cjs/puppeteer/common/JSHandle.js').ElementHandle; } catch (error) { - Super = require('puppeteer-core/lib/cjs/puppeteer/common/JSHandle').ElementHandle; + Super = require('puppeteer-core/lib/cjs/puppeteer/common/JSHandle.js').ElementHandle; } Super.prototype.clear = function () { diff --git a/source/puppeteer/lib/FrameManager.ts b/source/puppeteer/lib/FrameManager.ts index dc14ce1..ea8c530 100644 --- a/source/puppeteer/lib/FrameManager.ts +++ b/source/puppeteer/lib/FrameManager.ts @@ -4,9 +4,9 @@ import { KeysOfType, Prototype } from '../../../typings/chrome-aws-lambda'; let Super: Prototype = null; try { - Super = require('puppeteer/lib/cjs/puppeteer/common/FrameManager').Frame; + Super = require('puppeteer/lib/cjs/puppeteer/common/FrameManager.js').Frame; } catch (error) { - Super = require('puppeteer-core/lib/cjs/puppeteer/common/FrameManager').Frame; + Super = require('puppeteer-core/lib/cjs/puppeteer/common/FrameManager.js').Frame; } Super.prototype.clear = function (selector: string) { diff --git a/source/puppeteer/lib/Page.ts b/source/puppeteer/lib/Page.ts index 18e8406..f959fa9 100644 --- a/source/puppeteer/lib/Page.ts +++ b/source/puppeteer/lib/Page.ts @@ -4,9 +4,9 @@ import { KeysOfType, Prototype } from '../../../typings/chrome-aws-lambda'; let Super: Prototype = null; try { - Super = require('puppeteer/lib/cjs/puppeteer/common/Page').Page; + Super = require('puppeteer/lib/cjs/puppeteer/common/Page.js').Page; } catch (error) { - Super = require('puppeteer-core/lib/cjs/puppeteer/common/Page').Page; + Super = require('puppeteer-core/lib/cjs/puppeteer/common/Page.js').Page; } Super.prototype.block = function (predicates: string[]) { From 7a452f8c6c7c6620159f94147da7b487eeabf851 Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Thu, 19 May 2022 11:05:08 -0400 Subject: [PATCH 12/13] Add node 16 test --- _/amazon/template.yml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/_/amazon/template.yml b/_/amazon/template.yml index 5f13f47..589413a 100644 --- a/_/amazon/template.yml +++ b/_/amazon/template.yml @@ -23,3 +23,13 @@ Resources: Runtime: nodejs14.x Policies: - AWSLambdaBasicExecutionRole + + node16: + Type: AWS::Serverless::Function + Properties: + Layers: + - !Ref layer + Handler: handlers/index.handler + Runtime: nodejs16.x + Policies: + - AWSLambdaBasicExecutionRole From 9b421b6023ed68044ccfdfc597637f90b7469eaa Mon Sep 17 00:00:00 2001 From: Kyle McNally Date: Thu, 19 May 2022 11:05:28 -0400 Subject: [PATCH 13/13] Update to puppeteer v14.1.0 --- Makefile | 2 +- _/ansible/inventory.ini | 2 +- package.json | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index e7317dd..88b794b 100644 --- a/Makefile +++ b/Makefile @@ -9,7 +9,7 @@ clean: %.zip: npm install --no-fund --no-package-lock --no-shrinkwrap mkdir -p nodejs/ - npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@14.0.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap + npm install --prefix nodejs/ lambdafs@~2.0.3 puppeteer-core@14.1.0 --no-bin-links --no-fund --no-optional --no-package-lock --no-save --no-shrinkwrap npm pack mkdir -p nodejs/node_modules/chrome-aws-lambda/ tar --directory nodejs/node_modules/chrome-aws-lambda/ --extract --file chrome-aws-lambda-*.tgz --strip-components=1 diff --git a/_/ansible/inventory.ini b/_/ansible/inventory.ini index ccb7388..1e211a8 100644 --- a/_/ansible/inventory.ini +++ b/_/ansible/inventory.ini @@ -13,4 +13,4 @@ region=us-east-1 ansible_connection=ssh ansible_python_interpreter=auto_silent ansible_ssh_private_key_file=ansible.pem -puppeteer_version=v14.0.0 +puppeteer_version=v14.1.0 diff --git a/package.json b/package.json index d56c99a..a48848b 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "name": "chrome-aws-lambda", "private": false, - "version": "14.0.0", + "version": "14.1.0", "author": { "name": "Alix Axel" }, @@ -28,12 +28,12 @@ }, "devDependencies": { "@types/node": "^10.17.55", - "puppeteer-core": "14.0.0", + "puppeteer-core": "14.1.0", "rimraf": "^3.0.2", "typescript": "4.3.2" }, "peerDependencies": { - "puppeteer-core": "14.0.0" + "puppeteer-core": "14.1.0" }, "bugs": { "url": "https://github.com/alixaxel/chrome-aws-lambda/issues"