Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a11y contribution type #223

Merged

Conversation

phacks
Copy link
Contributor

@phacks phacks commented Nov 8, 2019

What: Add a11y (Accessibility) contribution type.

Why: Discussed in all-contributors/all-contributors#320

How: Added a new contribution type in src/util/contribution-types.js

Checklist:

  • Documentation: in another PR
  • Tests: I don’t think tests are needed for this PR, please tell me if you’d like some
  • Ready to be merged
  • Added myself to contributors table

I’ve yet to figure out how to add myself to the contributors table, can I use the @all-contributors bot to this end?

a11y: {
symbol: '️️️️♿️',
description: 'Accessibility',
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot a comma :)

Suggested change
}
},

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the permission to fix it myself. @phacks can you or someone with write access get this fix commited so we can merge the PR? I've already merged the PR for the website: all-contributors/all-contributors#326

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried fixing this but I don't have permission either, that being said I didn't try to fix that locally.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 🙈 I corrected this in 485e598, sorry about that!

@Berkmann18
Copy link
Member

I’ve yet to figure out how to add myself to the contributors table, can I use the @all-contributors bot to this end?

Don't worry about that part, we can always do that as this PR gets merged.

Copy link
Member

@Berkmann18 Berkmann18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you.

@phacks
Copy link
Contributor Author

phacks commented Nov 13, 2019

@Berkmann18 Hi! I think this PR can be merged, now that I fixed the typo and created all-contributors/app#259, what do you think?

@Berkmann18 Berkmann18 merged commit f38e0c8 into all-contributors:master Nov 13, 2019
@Berkmann18
Copy link
Member

@all-contributors Please add @phacks for code

@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @phacks! 🎉

@phacks phacks deleted the feat-add-a11y-contribution-type branch November 13, 2019 10:40
@all-contributors-release-bot
Copy link
Member

🎉 This PR is included in version 6.11.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants