Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom types don't work with the bot #324

Open
jakebolam opened this issue Jan 28, 2019 · 9 comments
Open

Custom types don't work with the bot #324

jakebolam opened this issue Jan 28, 2019 · 9 comments

Comments

@jakebolam
Copy link
Collaborator

Describe the bug
The configuration mentions custom types but the bot doesn't support it.

Expected behavior
Behaviour should match the documentation

@jakebolam jakebolam added the bug label Jan 28, 2019
@Berkmann18
Copy link
Member

There are also some predefined ones that it doesn't support but I'll look into that in a bit.

@lwasser
Copy link

lwasser commented Aug 28, 2019

i'm noticing this same behaviour here: https://github.com/pyOpenSci/pyopensci.github.io/blob/master/.all-contributorsrc @choldgraf perhaps it's a known bug??

@Berkmann18
Copy link
Member

@lwasser It's not a known bug as far as I know.
@gr2m @sinchang Did you guys encountered that before?

@lwasser
Copy link

lwasser commented Aug 30, 2019

oh interesting @Berkmann18 if we are doing something wrong please say the word. @choldgraf setup custom contrib types and the bot doesn't seem to recognize them. i went thru the docs last night and couldn't figure out what we are doing wrong. any guidance is appreciated!!

@gr2m
Copy link
Contributor

gr2m commented Aug 30, 2019

Hm I did not.

@rowasc
Copy link

rowasc commented Sep 5, 2019

Hey. Thanks for making this bot <3 .
Just wanted to mention I'm having the same issue. I tried different formats without luck... Maybe I'm just not getting it.

Should this work?

https://github.com/ushahidi/pwa-prototype-reporting/blob/master/.all-contributorsrc

  "types": {
    "mentoring": {
      "symbol": "👩‍🏫",
      "description": "Mentoring contributors.",
      "link": "[<%= symbol %>](<%= url %> \"<%= description %>\"),"
    }
  },

I can't find examples of this working in the wild

@Berkmann18
Copy link
Member

@rowasc AFAIK, there are no working examples for this (I'll happily be proven wrong tho).

@FBoucher
Copy link

Any idea, plan on when this bug could be fixed?

@tenshiAMD tenshiAMD transferred this issue from all-contributors/app Sep 16, 2022
@tenshiAMD tenshiAMD self-assigned this Sep 28, 2022
@Berkmann18
Copy link
Member

@FBoucher Have you tried with the latest versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants