You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We're currently in the process of upgrading our Angular project, which uses Betterer in combination with your exceptional plugin which allows us to gradually enforce stricter codebase parameters over time.
However, we've encountered a problem during our upgrade from Angular v15 to v17 and Typescript to its latest version, typescript@5.4.5. The issue arises with IDEs (WebStorm, IntelliJ IDEA Ultimate, VS Code) failing to display strictness issues in files which are strict.
After downgrading Typescript version by version in an attempt to pinpoint the problem, it seems the issue dissipates with version typescript@5.3.3.
To reproduce this issue, I've created a minimal Angular application located here. This application uses:
angular@17.3.5
typescript@5.4.5
typescript-strict-plugin@2.4.1
I initiated a new project using the Angular CLI, installed your current plugin, and configured it via tsconfig.json (disabling strictness and adding the plugin). In app.component, I inserted a strictness error. This error is not reported with typescript@5.4.x, yet is correctly identified with typescript@5.3.3. The snippet of code in question is as follows:
/**
* with typescript version higher than 5.3.3 this reports no strictness error, but it should.
* if we downgrade typescript to 5.3.3, a strictness error will be shown here.
*/
strictnessError(): string {
return undefined;
}
I noticed an issue with typescript@5.4 was reported and fixed last week as per this issue, but it seems there might still be a lingering problem.
Thanks in advance for your assistance!
Mariusz
The text was updated successfully, but these errors were encountered:
Greetings! 馃憢
We're currently in the process of upgrading our Angular project, which uses Betterer in combination with your exceptional plugin which allows us to gradually enforce stricter codebase parameters over time.
However, we've encountered a problem during our upgrade from Angular
v15
tov17
and Typescript to its latest version,typescript@5.4.5
. The issue arises with IDEs (WebStorm, IntelliJ IDEA Ultimate, VS Code) failing to display strictness issues in files which are strict.After downgrading Typescript version by version in an attempt to pinpoint the problem, it seems the issue dissipates with version
typescript@5.3.3
.To reproduce this issue, I've created a minimal Angular application located here. This application uses:
angular@17.3.5
typescript@5.4.5
typescript-strict-plugin@2.4.1
I initiated a new project using the Angular CLI, installed your current plugin, and configured it via
tsconfig.json
(disabling strictness and adding the plugin). Inapp.component
, I inserted a strictness error. This error is not reported withtypescript@5.4.x
, yet is correctly identified withtypescript@5.3.3
. The snippet of code in question is as follows:I noticed an issue with
typescript@5.4
was reported and fixed last week as per this issue, but it seems there might still be a lingering problem.Thanks in advance for your assistance!
Mariusz
The text was updated successfully, but these errors were encountered: