Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEs Fail to Display Strictness Issues with Typescript version 5.4.x #73

Closed
gingerr opened this issue Apr 19, 2024 · 3 comments
Closed

Comments

@gingerr
Copy link

gingerr commented Apr 19, 2024

Greetings! 馃憢

We're currently in the process of upgrading our Angular project, which uses Betterer in combination with your exceptional plugin which allows us to gradually enforce stricter codebase parameters over time.

However, we've encountered a problem during our upgrade from Angular v15 to v17 and Typescript to its latest version, typescript@5.4.5. The issue arises with IDEs (WebStorm, IntelliJ IDEA Ultimate, VS Code) failing to display strictness issues in files which are strict.

After downgrading Typescript version by version in an attempt to pinpoint the problem, it seems the issue dissipates with version typescript@5.3.3.

To reproduce this issue, I've created a minimal Angular application located here. This application uses:

  • angular@17.3.5
  • typescript@5.4.5
  • typescript-strict-plugin@2.4.1

I initiated a new project using the Angular CLI, installed your current plugin, and configured it via tsconfig.json (disabling strictness and adding the plugin). In app.component, I inserted a strictness error. This error is not reported with typescript@5.4.x, yet is correctly identified with typescript@5.3.3. The snippet of code in question is as follows:

  /**
   * with typescript version higher than 5.3.3 this reports no strictness error, but it should.
   * if we downgrade typescript to 5.3.3, a strictness error will be shown here.
   */
  strictnessError(): string {
    return undefined;
  }

I noticed an issue with typescript@5.4 was reported and fixed last week as per this issue, but it seems there might still be a lingering problem.

Thanks in advance for your assistance!
Mariusz

@km-tr
Copy link

km-tr commented Apr 22, 2024

I am also awake. Errors are no longer displayed in the typescript@5.4.3 environment.

@KostkaBrukowa
Copy link
Collaborator

I've released 2.4.2-beta.1 version. You can take a look and see if it helps

@KostkaBrukowa
Copy link
Collaborator

KostkaBrukowa commented May 2, 2024

Released with 2.4.3 version. Closing the issue. If the issue persists please reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants